Sign upLogin

werf/trdl

View on GitHub
Star

Showing 107 of 107 total issues

Method TufRepoRotator.Rotate has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
Open

func (rotator *TufRepoRotator) Rotate(logger hclog.Logger, now time.Time) error {
    var changedRoot, changedTargets, changedSnapshot, changedTimestamp bool

    logger.Debug("start rotating expiration timestamps and versions of TUF repository roles")
Severity: Minor
Found in server/pkg/publisher/tuf_repo_rotator.go - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method S3Repository.GenPrivKeys has 5 return statements (exceeds 4 allowed).
Open

func (repository *S3Repository) GenPrivKeys() error {
    if _, err := repository.TufRepo.GenKey("root"); err != nil {
        return fmt.Errorf("error generating tuf repository root key: %w", err)
    }
Severity: Major
Found in server/pkg/publisher/repository.go - About 35 mins to fix

    Function NewClient has 5 return statements (exceeds 4 allowed).
    Open

    func NewClient(repoUrl, metaLocalStoreDir, locksPath string) (*Client, error) {
    c := &Client{}
    c.metaLocalStoreDir = metaLocalStoreDir
    c.repoUrl = repoUrl
    Severity: Major
    Found in client/pkg/tuf/client.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  Operations: map[logical.Operation]framework.OperationHandler{
                logical.CreateOperation: &framework.PathOperation{
                    Description: "Configure Git credentials",
                    Callback:    pathConfigureGitCredentialCreateOrUpdate,
                },
      Severity: Minor
      Found in server/pkg/git/credentials.go and 1 other location - About 35 mins to fix
      server/pkg/pgp/backend.go on lines 66..79

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  Operations: map[logical.Operation]framework.OperationHandler{
                logical.ReadOperation: &framework.PathOperation{
                    Description: "Get the trusted PGP public key",
                    Callback:    pathConfigureTrustedPGPPublicKeyRead,
                },
      Severity: Minor
      Found in server/pkg/pgp/backend.go and 1 other location - About 35 mins to fix
      server/pkg/git/credentials.go on lines 41..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func putConfiguration(ctx context.Context, storage logical.Storage, cfg *configuration) error {
    entry, err := logical.StorageEntryJSON(storageKeyConfiguration, cfg)
    if err != nil {
        return err
    }
      Severity: Minor
      Found in server/pkg/tasks_manager/config_storage.go and 1 other location - About 30 mins to fix
      server/path_configure.go on lines 203..214

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func putConfiguration(ctx context.Context, storage logical.Storage, config *configuration) error {
    entry, err := logical.StorageEntryJSON(storageKeyConfiguration, config)
    if err != nil {
        return err
    }
      Severity: Minor
      Found in server/path_configure.go and 1 other location - About 30 mins to fix
      server/pkg/tasks_manager/config_storage.go on lines 26..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language