Sign upLogin

werf/trdl

View on GitHub
Star

Showing 107 of 107 total issues

Function ReadTarFromImageBuildResponse has a Cognitive Complexity of 65 (exceeds 20 allowed). Consider refactoring.
Open

func ReadTarFromImageBuildResponse(tarWriter, buildLogWriter io.Writer, response types.ImageBuildResponse) error {
    dec := json.NewDecoder(response.Body)
    currentState := checkingStartCode
    var codeCursor int
    var bufferedData []byte
Severity: Minor
Found in server/pkg/docker/image_build_response.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package main

import (
    "fmt"
Severity: Major
Found in client/cmd/trdl/bin_path.go and 1 other location - About 4 hrs to fix
client/cmd/trdl/dir_path.go on lines 1..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 344.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package main

import (
    "fmt"
Severity: Major
Found in client/cmd/trdl/dir_path.go and 1 other location - About 4 hrs to fix
client/cmd/trdl/bin_path.go on lines 1..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 344.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function ValidatePublishConfig has a Cognitive Complexity of 44 (exceeds 20 allowed). Consider refactoring.
Open

func ValidatePublishConfig(ctx context.Context, publisher publisher.Interface, publisherRepository publisher.RepositoryInterface, config *config.TrdlChannels, logger hclog.Logger) error {
    existingReleases, err := publisher.GetExistingReleases(ctx, publisherRepository)
    if err != nil {
        return fmt.Errorf("error getting existing targets: %w", err)
    }
Severity: Minor
Found in server/path_publish.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Backend.pathPublish has 124 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (b *Backend) pathPublish(ctx context.Context, req *logical.Request, fields *framework.FieldData) (*logical.Response, error) {
    if errResp := util.CheckRequiredFields(req, fields); errResp != nil {
        return errResp, nil
    }
Severity: Major
Found in server/path_publish.go - About 3 hrs to fix

    Method Backend.pathPublish has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
    Open

    func (b *Backend) pathPublish(ctx context.Context, req *logical.Request, fields *framework.FieldData) (*logical.Response, error) {
    if errResp := util.CheckRequiredFields(req, fields); errResp != nil {
        return errResp, nil
    }
    Severity: Minor
    Found in server/path_publish.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Backend.pathRelease has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
    Open

    func (b *Backend) pathRelease(ctx context.Context, req *logical.Request, fields *framework.FieldData) (*logical.Response, error) {
    if errResp := util.CheckRequiredFields(req, fields); errResp != nil {
        return errResp, nil
    }
    Severity: Minor
    Found in server/path_release.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Client has 29 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type Client struct {
    dir           string
    configuration configurationInterface
    locker        lockgate.Locker
}
    Severity: Minor
    Found in client/pkg/client/client.go - About 3 hrs to fix

      Function ForEachWorktreeFile has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.
      Open

      func ForEachWorktreeFile(gitRepo *git.Repository, fileFunc func(path, link string, fileReader io.Reader, info os.FileInfo) error) error {
    w, err := gitRepo.Worktree()
    if err != nil {
        return fmt.Errorf("unable to get git repository worktree: %w", err)
    }
      Severity: Minor
      Found in server/pkg/git/repository.go - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Manager.Paths has 109 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (m *Manager) Paths() []*framework.Path {
    return []*framework.Path{
        {
            Pattern:      pathPatternConfigure,
            HelpSynopsis: "Configure the task manager",
      Severity: Major
      Found in server/pkg/tasks_manager/backend.go - About 3 hrs to fix

        Method Backend.pathRelease has 109 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (b *Backend) pathRelease(ctx context.Context, req *logical.Request, fields *framework.FieldData) (*logical.Response, error) {
    if errResp := util.CheckRequiredFields(req, fields); errResp != nil {
        return errResp, nil
    }
        Severity: Major
        Found in server/path_release.go - About 3 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          func SplitFilepath(path string) (result []string) {
    path = filepath.FromSlash(path)
    separator := os.PathSeparator

    idx := 0
          Severity: Major
          Found in server/pkg/publisher/publisher.go and 1 other location - About 3 hrs to fix
          server/pkg/gendocs/util.go on lines 10..53

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 258.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          func SplitFilepath(path string) (result []string) {
    path = filepath.FromSlash(path)
    separator := os.PathSeparator

    idx := 0
          Severity: Major
          Found in server/pkg/gendocs/util.go and 1 other location - About 3 hrs to fix
          server/pkg/publisher/publisher.go on lines 353..396

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 258.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function configurePath has 79 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func configurePath(b *Backend) *framework.Path {
    return &framework.Path{
        Pattern:      "configure/?",
        HelpSynopsis: "Configure the plugin",
        Fields: map[string]*framework.FieldSchema{
          Severity: Major
          Found in server/path_configure.go - About 2 hrs to fix

            Function updateCmd has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
            Open

            func updateCmd() *cobra.Command {
    var noSelfUpdate bool
    var autoclean bool
    var inBackground bool
    var backgroundStdoutFile string
            Severity: Minor
            Found in client/cmd/trdl/update.go - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method Backend.pathPublish has 23 return statements (exceeds 4 allowed).
            Open

            func (b *Backend) pathPublish(ctx context.Context, req *logical.Request, fields *framework.FieldData) (*logical.Response, error) {
    if errResp := util.CheckRequiredFields(req, fields); errResp != nil {
        return errResp, nil
    }
            Severity: Major
            Found in server/path_publish.go - About 2 hrs to fix

              Function ReadTarFromImageBuildResponse has 73 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func ReadTarFromImageBuildResponse(tarWriter, buildLogWriter io.Writer, response types.ImageBuildResponse) error {
    dec := json.NewDecoder(response.Body)
    currentState := checkingStartCode
    var codeCursor int
    var bufferedData []byte
              Severity: Minor
              Found in server/pkg/docker/image_build_response.go - About 1 hr to fix

                Function NewMethodTemplateData has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
                Open

                func NewMethodTemplateData(name, path string, urlParameters []framework.OASParameter, methodDesc *framework.OASOperation, pathComponentSchema *framework.OASSchema) *MethodTemplateData {
    method := &MethodTemplateData{
        Name: name,
        Path: path,
    }
                Severity: Minor
                Found in server/pkg/gendocs/templates.go - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method Backend.pathRelease has 18 return statements (exceeds 4 allowed).
                Open

                func (b *Backend) pathRelease(ctx context.Context, req *logical.Request, fields *framework.FieldData) (*logical.Response, error) {
    if errResp := util.CheckRequiredFields(req, fields); errResp != nil {
        return errResp, nil
    }
                Severity: Major
                Found in server/path_release.go - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (c Client) GetRepoChannelReleaseBinDir(repoName, group, optionalChannel string) (string, error) {
    channel, err := c.processRepoOptionalChannel(repoName, optionalChannel)
    if err != nil {
        return "", err
    }
                  Severity: Major
                  Found in client/pkg/client/client.go and 1 other location - About 1 hr to fix
                  client/pkg/client/client.go on lines 331..355

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 169.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language