server/pkg/docker/image_build_response.go
Function ReadTarFromImageBuildResponse has a Cognitive Complexity of 65 (exceeds 20 allowed). Consider refactoring. Open
Open
func ReadTarFromImageBuildResponse(tarWriter, buildLogWriter io.Writer, response types.ImageBuildResponse) error {
dec := json.NewDecoder(response.Body)
currentState := checkingStartCode
var codeCursor int
var bufferedData []byte- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function ReadTarFromImageBuildResponse has 73 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func ReadTarFromImageBuildResponse(tarWriter, buildLogWriter io.Writer, response types.ImageBuildResponse) error {
dec := json.NewDecoder(response.Body)
currentState := checkingStartCode
var codeCursor int
var bufferedData []byteAvoid deeply nested control flow statements. Open
Open
if len(artifactsTarStopReadCode) > codeCursor+1 {
codeCursor++
} else {
return nil
}Avoid deeply nested control flow statements. Open
Open
if len(artifactsTarStartReadCode) > codeCursor+1 {
codeCursor++
startReadCodeSuspectedBytes = append(startReadCodeSuspectedBytes, b)
} else {Function ReadTarFromImageBuildResponse has 7 return statements (exceeds 4 allowed). Open
Open
func ReadTarFromImageBuildResponse(tarWriter, buildLogWriter io.Writer, response types.ImageBuildResponse) error {
dec := json.NewDecoder(response.Body)
currentState := checkingStartCode
var codeCursor int
var bufferedData []byteAvoid deeply nested control flow statements. Open
Open
} else if _, err := buildLogWriter.Write([]byte{b}); err != nil {
return fmt.Errorf("build log writer failed: %w", err)
}Avoid deeply nested control flow statements. Open
Open
if _, err := buildLogWriter.Write(append(startReadCodeSuspectedBytes, b)); err != nil {
return fmt.Errorf("build log writer failed: %w", err)
}