Sign upLogin

werf/trdl

View on GitHub
Star
server/pkg/pgp/backend.go

Summary

Maintainability
A
2 hrs
Test Coverage
A
92%

Function Paths has 63 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func Paths() []*framework.Path {
    return []*framework.Path{
        {
            Pattern:         "configure/trusted_pgp_public_key/?",
            HelpSynopsis:    "Configure trusted PGP public keys",
Severity: Minor
Found in server/pkg/pgp/backend.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                Operations: map[logical.Operation]framework.OperationHandler{
                logical.ReadOperation: &framework.PathOperation{
                    Description: "Get the trusted PGP public key",
                    Callback:    pathConfigureTrustedPGPPublicKeyRead,
                },
    Severity: Minor
    Found in server/pkg/pgp/backend.go and 1 other location - About 35 mins to fix
    server/pkg/git/credentials.go on lines 41..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status