Sign upLogin

werf/trdl

View on GitHub
Star
server/pkg/publisher/non_atomic_tuf_store.go

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Method NonAtomicTufStore.WalkStagedTargets has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func (store *NonAtomicTufStore) WalkStagedTargets(targetPathList []string, targetsFn tuf.TargetsWalkFunc) error {
    store.logger.Debug(fmt.Sprintf("-- NonAtomicTufStore.WalkStagedTargets %v", targetPathList))

    ctx := context.Background()
Severity: Minor
Found in server/pkg/publisher/non_atomic_tuf_store.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method NonAtomicTufStore.WalkStagedTargets has 6 return statements (exceeds 4 allowed).
Open

func (store *NonAtomicTufStore) WalkStagedTargets(targetPathList []string, targetsFn tuf.TargetsWalkFunc) error {
    store.logger.Debug(fmt.Sprintf("-- NonAtomicTufStore.WalkStagedTargets %v", targetPathList))

    ctx := context.Background()
Severity: Major
Found in server/pkg/publisher/non_atomic_tuf_store.go - About 40 mins to fix

    There are no issues that match your filters.

    Category
    Status