Sign upLogin

westtrade/cleantalk

View on GitHub
Star

Showing 17 of 17 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    spamCheck(...addressList) {

        addressList = flatten(addressList);

        const method_name = 'spam_check';
Severity: Major
Found in src/Cleantalk.js and 1 other location - About 4 hrs to fix
src/Cleantalk.js on lines 440..451

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    backlinksCheck(...domains) {

        domains = flatten(domains);

        const method_name = 'backlinks_check';
Severity: Major
Found in src/Cleantalk.js and 1 other location - About 4 hrs to fix
src/Cleantalk.js on lines 408..419

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function constructor has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    constructor({data, options, aliases, request} = {}) {
        if (request) {
            assert(request instanceof IncomingMessage, 'Request argument must be instance of http.ClientRequest.');
        }
Severity: Major
Found in src/CleantalkRequest.js - About 2 hrs to fix

    Function server has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const server = http.createServer((request, res) => {
    const {pathname, query} = url.parse(request.url);
    log('PATH', pathname);
    switch (true) {
    Severity: Major
    Found in examples/http/index.js - About 2 hrs to fix

      Function constructor has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          constructor({data, options, aliases, request} = {}) {
        if (request) {
            assert(request instanceof IncomingMessage, 'Request argument must be instance of http.ClientRequest.');
        }
      Severity: Minor
      Found in src/CleantalkRequest.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function requestMethod has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          [requestMethod] (requestUrl, data) {
        return new Promise((resolve, reject) => {

            const info = url.parse(requestUrl);
      Severity: Minor
      Found in src/Cleantalk.js - About 1 hr to fix

        Function constructor has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            constructor(responseData = {}) {

        assert.equal(typeof responseData, 'object', 'Argument responseData must be an object');

        let {
        Severity: Minor
        Found in src/CleantalkResponse.js - About 1 hr to fix

          Function checkMessage has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              checkMessage({sender_email, sender_ip, js_on, submit_time, all_headers, sender_nickname, message, sender_info, post_info, stoplist_check} = {}) {

        assert(sender_email, 'Sender email argument (sender_email) is required.');
        assert.equal(typeof sender_email, 'string', 'Sender email argument must be a string.');
          Severity: Minor
          Found in src/Cleantalk.js - About 1 hr to fix

            Function parseBody has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                [parseBody](request, bodyType = QUERYSTRING_BODY_TYPE) {

        return new Promise((resolve, reject) => {

            if (request.method === 'GET') {
            Severity: Minor
            Found in src/CleantalkRequest.js - About 1 hr to fix

              Function checkNewUser has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  checkNewUser({sender_email, sender_ip, js_on, submit_time, all_headers, sender_nickname, sender_info, tz, phone} = {}) {

        assert(sender_email, 'Sender email argument (sender_email) is required.');
        assert.equal(typeof sender_email, 'string', 'Sender email argument must be a string.');
              Severity: Minor
              Found in src/Cleantalk.js - About 1 hr to fix

                Function formTemplate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                const formTemplate = ({ errors, data }, auth_key) => {
    const disabledBecauseNoKey = auth_key ? '' : 'disabled';

    return `<!DOCTYPE html><html lang="en"><head><meta charset="UTF-8">
<title>Cleantalk demo - just try it!</title>
                Severity: Minor
                Found in examples/common/formTemplate.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    isAllowMessage(request) {
        assert(request instanceof CleantalkRequest, 'Argument request must be instance of CleantalkRequest');
        return request.ready.then(data => this.checkMessage(data));
    }
                Severity: Minor
                Found in src/Cleantalk.js and 1 other location - About 50 mins to fix
                src/Cleantalk.js on lines 155..158

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    isAllowUser(request) {
        assert(request instanceof CleantalkRequest, 'Argument request must be instance of CleantalkRequest');
        return request.ready.then(data => this.checkMessage(data));
    }
                Severity: Minor
                Found in src/Cleantalk.js and 1 other location - About 50 mins to fix
                src/Cleantalk.js on lines 140..143

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function checkMessage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    checkMessage({sender_email, sender_ip, js_on, submit_time, all_headers, sender_nickname, message, sender_info, post_info, stoplist_check} = {}) {

        assert(sender_email, 'Sender email argument (sender_email) is required.');
        assert.equal(typeof sender_email, 'string', 'Sender email argument must be a string.');
                Severity: Minor
                Found in src/Cleantalk.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function checkNewUser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    checkNewUser({sender_email, sender_ip, js_on, submit_time, all_headers, sender_nickname, sender_info, tz, phone} = {}) {

        assert(sender_email, 'Sender email argument (sender_email) is required.');
        assert.equal(typeof sender_email, 'string', 'Sender email argument must be a string.');
                Severity: Minor
                Found in src/Cleantalk.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function server has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const server = http.createServer((request, res) => {
    const {pathname, query} = url.parse(request.url);
    log('PATH', pathname);
    switch (true) {
                Severity: Minor
                Found in examples/http/index.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function cleantalkMiddleware has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const cleantalkMiddleware = (auth_key, type, aliases, options) =>  {

    options = options || {};
    const {server_url, language} = options;
                Severity: Minor
                Found in src/middlewares/express.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language