Sign upLogin

wgoodall01/shikaku

View on GitHub
Star
board.go

Summary

Maintainability
C
1 day
Test Coverage

Method Board.Solve has a Cognitive Complexity of 59 (exceeds 20 allowed). Consider refactoring.
Open

func (bo *Board) Solve() error {
    // Sanity check: all the squares, added together, actually cover the board
    totalCovered := 0
    bo.Iter(func(pos Vec2, sq *Square) bool {
        totalCovered += sq.Area
Severity: Minor
Found in board.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Board.Solve has 97 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (bo *Board) Solve() error {
    // Sanity check: all the squares, added together, actually cover the board
    totalCovered := 0
    bo.Iter(func(pos Vec2, sq *Square) bool {
        totalCovered += sq.Area
Severity: Major
Found in board.go - About 2 hrs to fix

    Method Board.Solve has 16 return statements (exceeds 4 allowed).
    Open

    func (bo *Board) Solve() error {
    // Sanity check: all the squares, added together, actually cover the board
    totalCovered := 0
    bo.Iter(func(pos Vec2, sq *Square) bool {
        totalCovered += sq.Area
    Severity: Major
    Found in board.go - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                                      if potential != giv {
                                    potential.AddPossible(r)
                                }
      Severity: Major
      Found in board.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status