Sign upLogin

whitesharx/httx

View on GitHub
Star
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static void CallOnBeforeRequestSent(this IRequest request, UnityWebRequest unityWebRequest) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var callbackObject = headers.FetchHeader<Callback<UnityWebRequest>>(InternalHeaders.HookObject);

      callbackObject?.OnBeforeRequestSent?.Invoke(unityWebRequest);
Severity: Major
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 1 hr to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 187..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static void CallOnOnResponseReceived(this IRequest request, UnityWebRequest unityWebRequest) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var callbackObject = headers.FetchHeader<Callback<UnityWebRequest>>(InternalHeaders.HookObject);

      callbackObject?.OnResponseReceived?.Invoke(unityWebRequest);
Severity: Major
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 1 hr to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 180..185

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static int FetchCacheItemMaxAge(this IRequest request) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var maxAge = headers.FetchHeader<int>(InternalHeaders.CacheItemMaxAge);

      return maxAge;
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 50 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 152..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static Condition FetchConditionObject(this IRequest request) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var condition = headers.FetchHeader<Condition>(InternalHeaders.ConditionObject);

      return condition;
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 50 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 166..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static CancellationToken FetchCancelToken(this IRequest request) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var token = headers.FetchHeader<CancellationToken>(InternalHeaders.CancelToken);

      return token;
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 50 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 173..178

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static bool IsMemoryCacheEnabled(this IRequest request) {
      var headers = request.ResolveHeaders()?.ToList() ?? new List<KeyValuePair<string, object>>();
      var isEnabled = headers.FetchHeader<bool>(InternalHeaders.MemoryCacheEnabled);

      return isEnabled;
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 1 other location - About 50 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 159..164

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      var mapperType = LeftToRight(request)
          .Select(r => ctx.ResolveMapper(r.GetType()))
          .LastOrDefault(t => null != t);
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 2 other locations - About 30 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 107..109
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 130..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      var awaiterType = LeftToRight(request)
          .Select(r => ctx.ResolveAwaiter(r.GetType()))
          .FirstOrDefault(t => null != t);
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 2 other locations - About 30 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 84..86
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 107..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      var mapperType = LeftToRight(request)
          .Select(r => ctx.ResolveMapper(r.GetType()))
          .FirstOrDefault(t => null != t);
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 2 other locations - About 30 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 84..86
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 130..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status