Sign upLogin

whitesharx/httx

View on GitHub
Star

Showing 149 of 150 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      var mapperType = LeftToRight(request)
          .Select(r => ctx.ResolveMapper(r.GetType()))
          .LastOrDefault(t => null != t);
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 2 other locations - About 30 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 107..109
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 130..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      var awaiterType = LeftToRight(request)
          .Select(r => ctx.ResolveAwaiter(r.GetType()))
          .FirstOrDefault(t => null != t);
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 2 other locations - About 30 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 84..86
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 107..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      var mapperType = LeftToRight(request)
          .Select(r => ctx.ResolveMapper(r.GetType()))
          .FirstOrDefault(t => null != t);
Severity: Minor
Found in Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs and 2 other locations - About 30 mins to fix
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 84..86
Assets/Httx/Runtime/Requests/Extensions/RequestExtensions.cs on lines 130..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

      return new AsyncOperationQueue(tryHitCache, netRequest, tryPutCache);
Severity: Major
Found in Assets/Httx/Runtime/Requests/Awaiters/BaseUnityAwaiter.cs - About 30 mins to fix

    Unexpected tabs found.
    Open

        <s:String x:Key="/Default/CodeEditing/Unity/AdditionalFileLayout/Pattern/@EntryValue">&lt;?xml version="1.0" encoding="utf-8"?&gt;
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/INDENT_NESTED_FOR_STMT/@EntryValue">True</s:Boolean>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/INDENT_NESTED_FOREACH_STMT/@EntryValue">True</s:Boolean>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/INDENT_PREPROCESSOR_REGION/@EntryValue">NO_INDENT</s:String>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Int64 x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/MAX_ARRAY_INITIALIZER_ELEMENTS_ON_LINE/@EntryValue">1</s:Int64>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/HtmlFormatter/TagSpaceBeforeHeaderEnd1/@EntryValue">True</s:Boolean>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Int64 x:Key="/Default/CodeStyle/CodeFormatting/XmlDocFormatter/INDENT_SIZE/@EntryValue">2</s:Int64>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:String x:Key="/Default/CustomTools/CustomToolsData/@EntryValue"></s:String>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=HeapView_002EObjectAllocation/@EntryIndexedValue">DO_NOT_SHOW</s:String>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=HeapView_002EObjectAllocation_002EEvident/@EntryIndexedValue">DO_NOT_SHOW</s:String>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Int64 x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/INDENT_SIZE/@EntryValue">2</s:Int64>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/KEEP_EXISTING_EMBEDDED_ARRANGEMENT/@EntryValue">False</s:Boolean>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/KEEP_EXISTING_INVOCATION_PARENS_ARRANGEMENT/@EntryValue">False</s:Boolean>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/LINE_FEED_AT_FILE_END/@EntryValue">True</s:Boolean>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Int64 x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/MAX_INVOCATION_ARGUMENTS_ON_LINE/@EntryValue">12</s:Int64>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig

    Unexpected tabs found.
    Open

        <s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/PLACE_ACCESSOR_WITH_ATTRS_HOLDER_ON_SINGLE_LINE/@EntryValue">True</s:Boolean>
    Severity: Minor
    Found in httx.sln.DotSettings by editorconfig
    Severity
    Category
    Status
    Source
    Language