Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/ResourceLoader/ClientHtml.php

Summary

Maintainability
D
2 days
Test Coverage

Function makeLoad has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    public static function makeLoad( Context $mainContext, array $modules, $only,
        array $extraQuery = []
    ) {
        $rl = $mainContext->getResourceLoader();
        $chunks = [];
Severity: Minor
Found in includes/ResourceLoader/ClientHtml.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getData has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    private function getData(): array {
        if ( $this->data ) {
            // @codeCoverageIgnoreStart
            return $this->data;
            // @codeCoverageIgnoreEnd
Severity: Minor
Found in includes/ResourceLoader/ClientHtml.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ClientHtml.php has 285 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/ResourceLoader/ClientHtml.php - About 2 hrs to fix

    Method makeLoad has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function makeLoad( Context $mainContext, array $modules, $only,
        array $extraQuery = []
    ) {
        $rl = $mainContext->getResourceLoader();
        $chunks = [];
    Severity: Major
    Found in includes/ResourceLoader/ClientHtml.php - About 2 hrs to fix

      Method getData has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getData(): array {
        if ( $this->data ) {
            // @codeCoverageIgnoreStart
            return $this->data;
            // @codeCoverageIgnoreEnd
      Severity: Major
      Found in includes/ResourceLoader/ClientHtml.php - About 2 hrs to fix

        Method getHeadHtml has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getHeadHtml( $nojsClass = null ) {
        $script = $this->getDocumentClassNameScript( $nojsClass );

        // Inline script: Declare mw.config variables for this page.
        if ( $this->config ) {
        Severity: Major
        Found in includes/ResourceLoader/ClientHtml.php - About 2 hrs to fix

          Function getHeadHtml has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getHeadHtml( $nojsClass = null ) {
        $script = $this->getDocumentClassNameScript( $nojsClass );

        // Inline script: Declare mw.config variables for this page.
        if ( $this->config ) {
          Severity: Minor
          Found in includes/ResourceLoader/ClientHtml.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status