Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/deferred/LinksUpdate/LinksTable.php

Summary

Maintainability
C
7 hrs
Test Coverage

LinksTable has 38 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class LinksTable {
    /** Link type: Inserted (added) links */
    public const INSERTED = 1;

    /** Link type: Deleted (removed) links */
Severity: Minor
Found in includes/deferred/LinksUpdate/LinksTable.php - About 5 hrs to fix

    Method doWrites has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function doWrites() {
        $db = $this->getDB();
        $table = $this->getTableName();
        $domainId = $db->getDomainID();
        $batchSize = $this->getBatchSize();
    Severity: Minor
    Found in includes/deferred/LinksUpdate/LinksTable.php - About 1 hr to fix

      Function update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          final public function update() {
        $this->startUpdate();
        $force = $this->needForcedLinkRefresh();
        foreach ( $this->getNewLinkIDs() as $link ) {
            if ( $force || !$this->isExisting( $link ) ) {
      Severity: Minor
      Found in includes/deferred/LinksUpdate/LinksTable.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return $this->getNewLinkIDs();
      Severity: Major
      Found in includes/deferred/LinksUpdate/LinksTable.php - About 30 mins to fix

        Function doWrites has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function doWrites() {
        $db = $this->getDB();
        $table = $this->getTableName();
        $domainId = $db->getDomainID();
        $batchSize = $this->getBatchSize();
        Severity: Minor
        Found in includes/deferred/LinksUpdate/LinksTable.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status