Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/libs/HashRing.php

Summary

Maintainability
C
1 day
Test Coverage

Function buildLocationRing has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function buildLocationRing( array $weightByLocation ) {
        $locationCount = count( $weightByLocation );
        $totalWeight = array_sum( $weightByLocation );

        $ring = [];
Severity: Minor
Found in includes/libs/HashRing.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findNodeIndexForPosition has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private function findNodeIndexForPosition( $position, $ring ) {
        $count = count( $ring );
        if ( $count === 0 ) {
            return null;
        }
Severity: Minor
Found in includes/libs/HashRing.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLocations has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function getLocations( $item, $limit, $from = self::RING_ALL ) {
        if ( $from === self::RING_ALL ) {
            $ring = $this->baseRing;
        } elseif ( $from === self::RING_LIVE ) {
            $ring = $this->getLiveRing();
Severity: Minor
Found in includes/libs/HashRing.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLiveRing has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getLiveRing() {
        if ( !$this->ejectExpiryByLocation ) {
            return $this->baseRing; // nothing ejected
        }
Severity: Minor
Found in includes/libs/HashRing.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buildLocationRing has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildLocationRing( array $weightByLocation ) {
        $locationCount = count( $weightByLocation );
        $totalWeight = array_sum( $weightByLocation );

        $ring = [];
Severity: Minor
Found in includes/libs/HashRing.php - About 1 hr to fix

    Method findNodeIndexForPosition has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function findNodeIndexForPosition( $position, $ring ) {
        $count = count( $ring );
        if ( $count === 0 ) {
            return null;
        }
    Severity: Minor
    Found in includes/libs/HashRing.php - About 1 hr to fix

      Method getLocations has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getLocations( $item, $limit, $from = self::RING_ALL ) {
        if ( $from === self::RING_ALL ) {
            $ring = $this->baseRing;
        } elseif ( $from === self::RING_LIVE ) {
            $ring = $this->getLiveRing();
      Severity: Minor
      Found in includes/libs/HashRing.php - About 1 hr to fix

        Method getLiveRing has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function getLiveRing() {
        if ( !$this->ejectExpiryByLocation ) {
            return $this->baseRing; // nothing ejected
        }
        Severity: Minor
        Found in includes/libs/HashRing.php - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status