wikimedia/mediawiki-core

View on GitHub
includes/libs/rdbms/ChronologyProtector.php

Summary

Maintainability
C
1 day
Test Coverage

File ChronologyProtector.php has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/libs/rdbms/ChronologyProtector.php - About 3 hrs to fix

    Method persistSessionReplicationPositions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function persistSessionReplicationPositions( &$clientPosIndex = null ) {
            $this->load();
            if ( !$this->enabled ) {
                return [];
            }
    Severity: Minor
    Found in includes/libs/rdbms/ChronologyProtector.php - About 1 hr to fix

      Method lazyStartup has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function lazyStartup() {
              if ( $this->startupTimestamp !== null ) {
                  return;
              }
      
      
      Severity: Minor
      Found in includes/libs/rdbms/ChronologyProtector.php - About 1 hr to fix

        Method load has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function load() {
                // Not enabled or already loaded, short-circuit.
                if ( !$this->enabled || $this->clientId ) {
                    return;
                }
        Severity: Minor
        Found in includes/libs/rdbms/ChronologyProtector.php - About 1 hr to fix

          Function lazyStartup has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function lazyStartup() {
                  if ( $this->startupTimestamp !== null ) {
                      return;
                  }
          
          
          Severity: Minor
          Found in includes/libs/rdbms/ChronologyProtector.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function mergePositions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function mergePositions(
                  $storedValue,
                  array $shutdownPositions,
                  array $shutdownTimestamps,
                  ?int &$clientPosIndex = null
          Severity: Minor
          Found in includes/libs/rdbms/ChronologyProtector.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function stageSessionPrimaryPos has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function stageSessionPrimaryPos( ILoadBalancer $lb ) {
                  $this->load();
                  if ( !$this->enabled || !$lb->hasOrMadeRecentPrimaryChanges( INF ) ) {
                      return;
                  }
          Severity: Minor
          Found in includes/libs/rdbms/ChronologyProtector.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return [ 'index' => $index, 'clientId' => $clientId ];
          Severity: Major
          Found in includes/libs/rdbms/ChronologyProtector.php - About 30 mins to fix

            Function persistSessionReplicationPositions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function persistSessionReplicationPositions( &$clientPosIndex = null ) {
                    $this->load();
                    if ( !$this->enabled ) {
                        return [];
                    }
            Severity: Minor
            Found in includes/libs/rdbms/ChronologyProtector.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function load() {
                    // Not enabled or already loaded, short-circuit.
                    if ( !$this->enabled || $this->clientId ) {
                        return;
                    }
            Severity: Minor
            Found in includes/libs/rdbms/ChronologyProtector.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status