Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/objectcache/ObjectCacheFactory.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function prepareSqlBagOStuffFromParams has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private function prepareSqlBagOStuffFromParams( array &$params ): void {
        if ( isset( $params['globalKeyLB'] ) ) {
            throw new InvalidArgumentException(
                'globalKeyLB in $wgObjectCaches is no longer supported' );
        }
Severity: Minor
Found in includes/objectcache/ObjectCacheFactory.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method newFromParams has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function newFromParams( array $params ): BagOStuff {
        $logger = $this->logger->getLogger( $params['loggroup'] ?? 'objectcache' );
        // Apply default parameters and resolve the logger instance
        $params += [
            'logger' => $logger,
Severity: Minor
Found in includes/objectcache/ObjectCacheFactory.php - About 1 hr to fix

    Method prepareSqlBagOStuffFromParams has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function prepareSqlBagOStuffFromParams( array &$params ): void {
        if ( isset( $params['globalKeyLB'] ) ) {
            throw new InvalidArgumentException(
                'globalKeyLB in $wgObjectCaches is no longer supported' );
        }
    Severity: Minor
    Found in includes/objectcache/ObjectCacheFactory.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ServiceOptions $options,
        StatsFactory $stats,
        Spi $loggerSpi,
        callable $dbLoadBalancerFactory,
        string $domainId
      Severity: Minor
      Found in includes/objectcache/ObjectCacheFactory.php - About 35 mins to fix

        Function newFromId has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function newFromId( $id ): BagOStuff {
        if ( $id === CACHE_ANYTHING ) {
            $id = ObjectCache::getAnythingId();
        }
        Severity: Minor
        Found in includes/objectcache/ObjectCacheFactory.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function newFromParams has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function newFromParams( array $params ): BagOStuff {
        $logger = $this->logger->getLogger( $params['loggroup'] ?? 'objectcache' );
        // Apply default parameters and resolve the logger instance
        $params += [
            'logger' => $logger,
        Severity: Minor
        Found in includes/objectcache/ObjectCacheFactory.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status