wikimedia/mediawiki-core

View on GitHub

Showing 11,545 of 11,545 total issues

SpecialUserRights has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class SpecialUserRights extends SpecialPage {
    /**
     * The target of the local right-adjuster's interest.  Can be gotten from
     * either a GET parameter or a subpage-style parameter, so have a member
     * variable for it.
Severity: Minor
Found in includes/specials/SpecialUserRights.php - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                if ( $attribute === 'rel' || $attribute === 'rev'
                    # RDFa
                    || $attribute === 'about' || $attribute === 'property'
                    || $attribute === 'resource' || $attribute === 'datatype'
                    || $attribute === 'typeof'
    Severity: Critical
    Found in includes/parser/Sanitizer.php - About 2 hrs to fix

      PageHistoryCountHandler has 24 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class PageHistoryCountHandler extends SimpleHandler {
      
          /** The maximum number of counts to return per type of revision */
          private const COUNT_LIMITS = [
              'anonymous' => 10000,
      Severity: Minor
      Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 2 hrs to fix

        ChangesListFilter has 24 functions (exceeds 20 allowed). Consider refactoring.
        Open

        abstract class ChangesListFilter {
            /**
             * Filter name
             *
             * @var string
        Severity: Minor
        Found in includes/recentchanges/ChangesListFilter.php - About 2 hrs to fix

          RecompressTracked has 24 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class RecompressTracked {
              /** @var string[] */
              public $destClusters;
              /** @var int */
              public $batchSize = 1000;
          Severity: Minor
          Found in maintenance/storage/recompressTracked.php - About 2 hrs to fix

            CategoryChangesAsRdf has 24 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class CategoryChangesAsRdf extends Maintenance {
                /**
                 * Insert query
                 */
                private const SPARQL_INSERT = <<<SPARQL
            Severity: Minor
            Found in maintenance/categoryChangesAsRdf.php - About 2 hrs to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          switch ( word ) {
                              case 'an Domhnach':
                                  word = 'Dé Domhnaigh';
                                  break;
                              case 'an Luan':
              Severity: Major
              Found in resources/src/mediawiki.language/languages/ga.js and 1 other location - About 2 hrs to fix
              resources/lib/jquery.i18n/src/languages/ga.js on lines 11..33

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 88.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              switch ( word ) {
                                  case 'an Domhnach':
                                      word = 'Dé Domhnaigh';
                                      break;
                                  case 'an Luan':
              Severity: Major
              Found in resources/lib/jquery.i18n/src/languages/ga.js and 1 other location - About 2 hrs to fix
              resources/src/mediawiki.language/languages/ga.js on lines 12..34

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 88.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              File ImageModule.php has 277 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              /**
               * This program is free software; you can redistribute it and/or modify
               * it under the terms of the GNU General Public License as published by
               * the Free Software Foundation; either version 2 of the License, or
              Severity: Minor
              Found in includes/ResourceLoader/ImageModule.php - About 2 hrs to fix

                File UrlUtils.php has 277 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                namespace MediaWiki\Utils;
                
                use BadMethodCallException;
                Severity: Minor
                Found in includes/utils/UrlUtils.php - About 2 hrs to fix

                  File ApiQueryDeletedRevisions.php has 277 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  /**
                   * Copyright © 2014 Wikimedia Foundation and contributors
                   *
                   * Heavily based on ApiQueryDeletedrevs,
                  Severity: Minor
                  Found in includes/api/ApiQueryDeletedRevisions.php - About 2 hrs to fix

                    File SpecialRecentChangesLinked.php has 277 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    /**
                     * This program is free software; you can redistribute it and/or modify
                     * it under the terms of the GNU General Public License as published by
                     * the Free Software Foundation; either version 2 of the License, or
                    Severity: Minor
                    Found in includes/specials/SpecialRecentChangesLinked.php - About 2 hrs to fix

                      File LocalFileRestoreBatch.php has 277 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      /**
                       * This program is free software; you can redistribute it and/or modify
                       * it under the terms of the GNU General Public License as published by
                       * the Free Software Foundation; either version 2 of the License, or
                      Severity: Minor
                      Found in includes/filerepo/file/LocalFileRestoreBatch.php - About 2 hrs to fix

                        Function MwRcfiltersUiFilterMenuSectionOptionWidget has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        const FilterMenuSectionOptionWidget = function MwRcfiltersUiFilterMenuSectionOptionWidget( controller, model, config ) {
                            const $header = $( '<div>' )
                                    .addClass( 'mw-rcfilters-ui-filterMenuSectionOptionWidget-header' ),
                                $popupContent = $( '<div>' )
                                    .addClass( 'mw-rcfilters-ui-filterMenuSectionOptionWidget-whatsThisButton-popup-content' );
                        Severity: Major
                        Found in resources/src/mediawiki.rcfilters/ui/FilterMenuSectionOptionWidget.js - About 2 hrs to fix

                          Function doProcess has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  const doProcess = function ( placeholder, target ) {
                                      target = prefix + target;
                          
                                      if ( !layout.widgets[ target ] ) {
                                          // The target wasn't processed yet, try the next one.
                          Severity: Major
                          Found in resources/src/mediawiki.special.apisandbox/apisandbox.js - About 2 hrs to fix

                            Function autoUpdate has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function autoUpdate(reference, floating, update, options) {
                              if (options === void 0) {
                                options = {};
                              }
                              const {
                            Severity: Major
                            Found in resources/lib/codex/codex.js - About 2 hrs to fix

                              Function observeMove has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              function observeMove(element, onMove) {
                                let io = null;
                                let timeoutId;
                                const root = getDocumentElement(element);
                                function cleanup() {
                              Severity: Major
                              Found in resources/lib/codex/codex.js - About 2 hrs to fix

                                Method __construct has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    public function __construct( $priority, array $data ) {
                                        if ( $priority < self::MIN_PRIORITY || $priority > self::MAX_PRIORITY ) {
                                            throw new InvalidArgumentException( 'Invalid priority' );
                                        }
                                
                                
                                Severity: Major
                                Found in includes/session/SessionInfo.php - About 2 hrs to fix

                                  Method updateCategoryCounts has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      public function updateCategoryCounts( array $added, array $deleted, $id = 0 ) {
                                          $id = $id ?: $this->getId();
                                          // Guard against data corruption T301433
                                          $added = array_map( 'strval', $added );
                                          $deleted = array_map( 'strval', $deleted );
                                  Severity: Major
                                  Found in includes/page/WikiPage.php - About 2 hrs to fix

                                    Method continueLinkAttempt has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        protected function continueLinkAttempt( $user, $key, array $reqs ) {
                                            $req = ButtonAuthenticationRequest::getRequestByName( $reqs, 'linkOk' );
                                            if ( $req ) {
                                                return AuthenticationResponse::newPass();
                                            }
                                    Severity: Major
                                    Found in includes/auth/ConfirmLinkSecondaryAuthenticationProvider.php - About 2 hrs to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language