Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star

Showing 11,545 of 11,545 total issues

Method _set has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function _set( $cmd, $key, $val, $exp, $casToken = null ) {
        $this->_last_cmd_status = self::ERR_NONE;

        if ( !$this->_active ) {
            $this->_last_cmd_status = self::ERR_UNEXPECTED;
Severity: Major
Found in includes/libs/objectcache/utils/MemcachedClient.php - About 2 hrs to fix

    Method hebrewNumeral has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function hebrewNumeral( $num ) {
        static $table = [
            [ '', 'א', 'ב', 'ג', 'ד', 'ה', 'ו', 'ז', 'ח', 'ט', 'י' ],
            [ '', 'י', 'כ', 'ל', 'מ', 'נ', 'ס', 'ע', 'פ', 'צ', 'ק' ],
            [ '',
    Severity: Major
    Found in includes/language/Language.php - About 2 hrs to fix

      Method execute has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function execute() {
        if ( $this->getVar( '_ExistingDBSettings' ) ) {
            return 'skip';
        }
      Severity: Major
      Found in includes/installer/WebInstallerDBConnect.php - About 2 hrs to fix

        Method run has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function run( $resultPageSet = null ) {
        $params = $this->extractRequestParams();

        $prop = array_fill_keys( $params['prop'], true );
        $fld_ids = isset( $prop['ids'] );
        Severity: Major
        Found in includes/api/ApiQueryPagesWithProp.php - About 2 hrs to fix

          Method show has 61 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function show( FormOptions $opts, array $extraConds ) {
        # Create a LogPager item to get the results and a LogEventsList item to format them...
        $loglist = new LogEventsList(
            $this->getContext(),
            $this->getLinkRenderer(),
          Severity: Major
          Found in includes/specials/SpecialLog.php - About 2 hrs to fix

            Method getQueryInfo has 61 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getQueryInfo() {
        $rcQuery = RecentChange::getQueryInfo();

        $conds = [];
        $conds['rc_new'] = 1;
            Severity: Major
            Found in includes/specials/pagers/NewPagesPager.php - About 2 hrs to fix

              Method getQueryInfo has 61 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getQueryInfo( $data = null ) {
        $dbr = $this->getDatabase();

        $activeUserSeconds = $this->getConfig()->get( MainConfigNames::ActiveUserDays ) * 86400;
        $timestamp = $dbr->timestamp( (int)wfTimestamp( TS_UNIX ) - $activeUserSeconds );
              Severity: Major
              Found in includes/specials/pagers/ActiveUsersPager.php - About 2 hrs to fix

                Method normalizeSubpageLink has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function normalizeSubpageLink( $contextTitle, $target, &$text ) {
        # Valid link forms:
        # Foobar -- normal
        # :Foobar -- override special treatment of prefix (images, language links)
        # /Foobar -- convert to CurrentPage/Foobar
                Severity: Major
                Found in includes/linker/Linker.php - About 2 hrs to fix

                  Method extensionSubstitution has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function extensionSubstitution( array $params, PPFrame $frame, bool $processNowiki = false ) {
        static $errorStr = '<span class="error">';

        $name = $frame->expand( $params['name'] );
        if ( str_starts_with( $name, $errorStr ) ) {
                  Severity: Major
                  Found in includes/parser/Parser.php - About 2 hrs to fix

                    Method loadFromCache has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function loadFromCache() {
        $this->dataLoaded = false;
        $this->extraDataLoaded = false;

        $key = $this->getCacheKey();
                    Severity: Major
                    Found in includes/filerepo/file/LocalFile.php - About 2 hrs to fix

                      Method checkFiles has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function checkFiles( LocalRepo $repo, array $paths, $verbose ) {
        if ( !count( $paths ) ) {
            return;
        }
                      Severity: Major
                      Found in maintenance/findOrphanedFiles.php - About 2 hrs to fix

                        Method doDBUpdates has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function doDBUpdates() {
        $batchSize = $this->getBatchSize();

        $dbw = $this->getDB( DB_PRIMARY );
        if ( !$dbw->fieldExists( 'revision', 'rev_actor', __METHOD__ ) ) {
                        Severity: Major
                        Found in maintenance/migrateRevisionActorTemp.php - About 2 hrs to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  $handler = function ( array $request, StatusValue $status ) use ( $method, $params ) {
            [ $rcode, $rdesc, , $rbody, $rerr ] = $request['response'];
            if ( $rcode === 201 || $rcode === 202 ) {
                // good
            } elseif ( $rcode === 412 ) {
                          Severity: Major
                          Found in includes/libs/filebackend/SwiftFileBackend.php and 1 other location - About 2 hrs to fix
                          includes/libs/filebackend/SwiftFileBackend.php on lines 316..327

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 130.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  try {
            $user = $this->actorStore->newActorFromRowFields(
                $row->ar_user ?? null,
                $row->ar_user_text ?? null,
                $row->ar_actor ?? null
                          Severity: Major
                          Found in includes/Revision/RevisionStore.php and 1 other location - About 2 hrs to fix
                          includes/Revision/RevisionStore.php on lines 1755..1770

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 130.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  $handler = function ( array $request, StatusValue $status ) use ( $method, $params ) {
            [ $rcode, $rdesc, , $rbody, $rerr ] = $request['response'];
            if ( $rcode === 201 || $rcode === 202 ) {
                // good
            } elseif ( $rcode === 412 ) {
                          Severity: Major
                          Found in includes/libs/filebackend/SwiftFileBackend.php and 1 other location - About 2 hrs to fix
                          includes/libs/filebackend/SwiftFileBackend.php on lines 404..415

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 130.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  try {
            $user = $this->actorStore->newActorFromRowFields(
                $row->rev_user ?? null,
                $row->rev_user_text ?? null,
                $row->rev_actor ?? null
                          Severity: Major
                          Found in includes/Revision/RevisionStore.php and 1 other location - About 2 hrs to fix
                          includes/Revision/RevisionStore.php on lines 1673..1688

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 130.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          File CookieSessionProvider.php has 268 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          <?php
/**
 * MediaWiki cookie-based session provider interface
 *
 * This program is free software; you can redistribute it and/or modify
                          Severity: Minor
                          Found in includes/session/CookieSessionProvider.php - About 2 hrs to fix

                            File PreferencesFormOOUI.php has 268 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
                            Severity: Minor
                            Found in includes/specials/forms/PreferencesFormOOUI.php - About 2 hrs to fix

                              Function setup has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                              Open

                                setup(props, { emit, attrs, slots }) {
    const input = ref();
    const inputWrapper = ref();
    const menu = ref();
    const menuId = useGeneratedId("combobox");
                              Severity: Minor
                              Found in resources/lib/codex/codex.js - About 2 hrs to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function useFloatingMenu has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function useFloatingMenu(referenceElement, menu, opt) {
  var _a;
  const menuIsExpanded = () => {
    var _a2;
    return (_a2 = menu.value) == null ? void 0 : _a2.isExpanded();
                              Severity: Minor
                              Found in resources/lib/codex/codex.js - About 2 hrs to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language