wikimedia/mediawiki-core

View on GitHub

Showing 11,545 of 11,545 total issues

File ParserOutputAccess.php has 409 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/page/ParserOutputAccess.php - About 5 hrs to fix

    File Module.php has 409 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * This program is free software; you can redistribute it and/or modify
     * it under the terms of the GNU General Public License as published by
     * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/ResourceLoader/Module.php - About 5 hrs to fix

      File ActorStore.php has 409 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      /**
       * This program is free software; you can redistribute it and/or modify
       * it under the terms of the GNU General Public License as published by
       * the Free Software Foundation; either version 2 of the License, or
      Severity: Minor
      Found in includes/user/ActorStore.php - About 5 hrs to fix

        Function URL has 145 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function URL(url, base) {
                    if (!(this instanceof global.URL))
                        throw new TypeError("Failed to construct 'URL': Please use the 'new' operator.");
        
                    if (base) {
        Severity: Major
        Found in resources/lib/url/URL.js - About 5 hrs to fix

          Method sendInternal has 145 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected static function sendInternal(
                  array $to,
                  MailAddress $from,
                  $subject,
                  $body,
          Severity: Major
          Found in includes/mail/UserMailer.php - About 5 hrs to fix

            Method showLogExtract has 145 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function showLogExtract(
                    &$out, $types = [], $page = '', $user = '', $param = []
                ) {
                    $defaultParameters = [
                        'lim' => 25,
            Severity: Major
            Found in includes/logging/LogEventsList.php - About 5 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (withoutSuffix) {
                          switch (string) {
                              case 's':
                                  output = 'काही सेकंद';
                                  break;
              Severity: Major
              Found in resources/lib/moment/locale/mr.js and 1 other location - About 5 hrs to fix
              resources/lib/moment/locale/mr.js on lines 81..120

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 151.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      } else {
                          switch (string) {
                              case 's':
                                  output = 'काही सेकंदां';
                                  break;
              Severity: Major
              Found in resources/lib/moment/locale/mr.js and 1 other location - About 5 hrs to fix
              resources/lib/moment/locale/mr.js on lines 42..81

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 151.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              File jquery.ui.widget.js has 407 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /*!
               * jQuery UI Widget 1.9.2
               * http://jqueryui.com
               *
               * Copyright 2012 jQuery Foundation and other contributors
              Severity: Minor
              Found in resources/lib/jquery.ui/jquery.ui.widget.js - About 5 hrs to fix

                Function makeApi has 144 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function makeApi(sinon) {
                        sinon.xdr = xdr;
                
                        function FakeXDomainRequest() {
                            this.readyState = FakeXDomainRequest.UNSENT;
                Severity: Major
                Found in resources/lib/sinonjs/sinon.js - About 5 hrs to fix

                  Method updateTags has 144 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function updateTags( $tagsToAdd, $tagsToRemove, &$rc_id = null,
                          &$rev_id = null, &$log_id = null, $params = null, RecentChange $rc = null,
                          UserIdentity $user = null
                      ) {
                          $tagsToAdd = array_filter(
                  Severity: Major
                  Found in includes/changetags/ChangeTagsStore.php - About 5 hrs to fix

                    Function importFormDataPosted has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function importFormDataPosted( WebRequest $request ): void {
                            # These fields need to be checked for encoding.
                            # Also remove trailing whitespace, but don't remove _initial_
                            # whitespace from the text boxes. This may be significant formatting.
                            $this->textbox1 = rtrim( $request->getText( 'wpTextbox1' ) );
                    Severity: Minor
                    Found in includes/editpage/EditPage.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function sendInternal has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected static function sendInternal(
                            array $to,
                            MailAddress $from,
                            $subject,
                            $body,
                    Severity: Minor
                    Found in includes/mail/UserMailer.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function resyncFiles has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function resyncFiles( array $paths, $resyncMode = true ) {
                            $status = $this->newStatus();
                    
                            $fname = __METHOD__;
                            foreach ( $paths as $path ) {
                    Severity: Minor
                    Found in includes/libs/filebackend/FileBackendMultiWrite.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function newLoad has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function newLoad(
                            $specificTarget,
                            $specificType,
                            $fromPrimary,
                            $vagueTarget = null
                    Severity: Minor
                    Found in includes/block/DatabaseBlockStore.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function extractTitle has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected static function extractTitle( $path, $pattern ) {
                            // Convert the path pattern into a regexp we can match with
                            $regexp = preg_quote( $pattern->path, '#' );
                            // .* for the $1
                            $regexp = preg_replace( '#\\\\\$1#u', '(?P<par1>.*)', $regexp );
                    Severity: Minor
                    Found in includes/Request/PathRouter.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function execute has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function execute( $subPage ) {
                            if ( $this->mPosted ) {
                                $time = microtime( true );
                                $profilingScope = new ScopedCallback( function () use ( $time ) {
                                    $time = microtime( true ) - $time;
                    Severity: Minor
                    Found in includes/specialpage/LoginSignupSpecialPage.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function prepareQuery has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function prepareQuery( array $users, $limit ) {
                            $this->resetQueryParams();
                            $db = $this->getDB();
                    
                            $queryBuilder = $this->revisionStore->newSelectQueryBuilder( $db )->joinComment()->joinPage();
                    Severity: Minor
                    Found in includes/api/ApiQueryUserContribs.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function run has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function run( $resultPageSet = null ) {
                            $pages = $this->getPageSet()->getGoodPages();
                            if ( $pages === [] ) {
                                return; // nothing to do
                            }
                    Severity: Minor
                    Found in includes/api/ApiQueryLinks.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function showChunk has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function showChunk(
                            $namespace = NS_MAIN, $from = null, $to = null, $hideredirects = false
                        ) {
                            $output = $this->getOutput();
                    
                    
                    Severity: Minor
                    Found in includes/specials/SpecialAllPages.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language