Showing 11,545 of 11,545 total issues
Function getFileInfo
has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring. Open
public function getFileInfo( IPageConfig $pageConfig, array $files ): array {
$page = Title::newFromLinkTarget( $pageConfig->getLinkTarget() );
$keys = [];
foreach ( $files as $f ) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function checkSvgScriptCallback
has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring. Open
public function checkSvgScriptCallback( $element, $attribs, $data = null ) {
[ $namespace, $strippedElement ] = self::splitXmlNamespace( $element );
// We specifically don't include:
// http://www.w3.org/1999/xhtml (T62771)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File ArchivedFile.php
has 392 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
Function justify
has 135 lines of code (exceeds 25 allowed). Consider refactoring. Open
function justify() {
let lastTop,
rows = [],
$gallery = $( this );
Method setOldSubtitle
has 135 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function setOldSubtitle( $oldid = 0 ) {
if ( !$this->getHookRunner()->onDisplayOldSubtitle( $this, $oldid ) ) {
return;
}
Method getCreditsForExtension
has 135 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCreditsForExtension( $type, array $extension ) {
$out = $this->getOutput();
// We must obtain the information for all the bits and pieces!
// ... such as extension names and links
File upload.js
has 391 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
* JavaScript for Special:Upload
*
* @private
* @class mw.special.upload
Function parseDate
has 134 lines of code (exceeds 25 allowed). Consider refactoring. Open
parseDate: function (format, value, settings) {
if (format == null || value == null)
throw 'Invalid arguments';
value = (typeof value == 'object' ? value.toString() : value + '');
if (value == '')
Method execute
has 134 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function execute( $subPage ) {
if ( $this->mPosted ) {
$time = microtime( true );
$profilingScope = new ScopedCallback( function () use ( $time ) {
$time = microtime( true ) - $time;
Method rename
has 134 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function rename() {
$dbw = $this->dbProvider->getPrimaryDatabase();
$atomicId = $dbw->startAtomic( __METHOD__, $dbw::ATOMIC_CANCELABLE );
$this->hookRunner->onRenameUserPreRename( $this->uid, $this->old, $this->new );
Method extractOutputData
has 134 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function extractOutputData( WatchedItem $watchedItem, array $recentChangeInfo ) {
/* Determine the title of the page that has been changed. */
$target = $watchedItem->getTarget();
if ( $target instanceof LinkTarget ) {
$title = Title::newFromLinkTarget( $target );
File ApiQueryBlocks.php
has 390 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Copyright © 2007 Roan Kattouw <roan.kattouw@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
File SpecialNewPages.php
has 390 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
File MessagesFa.php
has 390 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/** Persian (فارسی)
*
* @file
* @ingroup Languages
Method execute
has 134 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function execute() {
$userName = $this->getOption( 'user', false );
$summary = $this->getOption( 'summary', 'Imported from text file' );
$useTimestamp = $this->hasOption( 'use-timestamp' );
$rc = $this->hasOption( 'rc' );
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ( !this.sawWheelEvent ) {
if ( event.originalEvent.wheelDeltaX ) {
delta = -event.originalEvent.wheelDeltaX;
} else if ( event.originalEvent.wheelDeltaY ) {
delta = event.originalEvent.wheelDeltaY;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 142.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ( !this.sawWheelEvent ) {
if ( e.originalEvent.wheelDeltaX ) {
delta = -e.originalEvent.wheelDeltaX;
} else if ( e.originalEvent.wheelDeltaY ) {
delta = e.originalEvent.wheelDeltaY;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 142.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
File WikiExporter.php
has 389 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Base class for exporting
*
* Copyright © 2003, 2005, 2006 Brooke Vibber <bvibber@wikimedia.org>
File McrUndoAction.php
has 389 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Temporary action for MCR undos
* @file
* @ingroup Actions
File MediaWikiTitleCodec.php
has 389 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* A codec for MediaWiki page titles.
*
* This program is free software; you can redistribute it and/or modify