Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star

Showing 11,545 of 11,545 total issues

Function streamThumb has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    protected function streamThumb( array $params ) {
        $headers = []; // HTTP headers to send

        $fileName = $params['f'] ?? '';
Severity: Minor
Found in includes/filerepo/ThumbnailEntryPoint.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findOrphanBlobs has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    private function findOrphanBlobs() {
        if ( !extension_loaded( 'gmp' ) ) {
            echo "Can't find orphan blobs, need bitfield support provided by GMP.\n";

            return;
Severity: Minor
Found in maintenance/storage/trackBlobs.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bench has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    public function bench( array $benchs ) {
        $this->startBench();
        $count = $this->getOption( 'count', $this->defaultCount );
        $verbose = $this->hasOption( 'verbose' );
Severity: Minor
Found in maintenance/includes/Benchmarker.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if pyversion[:1] in ['2']:
        t2s_1to1 = dict([(f, t) for (f, t) in t2s_1to1.iteritems() if f != t])
    else:
        t2s_1to1 = dict([(f, t) for (f, t) in t2s_1to1.items() if f != t])
Severity: Major
Found in maintenance/language/zhtable/Makefile.py and 1 other location - About 5 hrs to fix
maintenance/language/zhtable/Makefile.py on lines 395..398

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if pyversion[:1] in ['2']:
        s2t_1to1 = dict([(f, t) for (f, t) in s2t_1to1.iteritems() if f != t])
    else:
        s2t_1to1 = dict([(f, t) for (f, t) in s2t_1to1.items() if f != t])
Severity: Major
Found in maintenance/language/zhtable/Makefile.py and 1 other location - About 5 hrs to fix
maintenance/language/zhtable/Makefile.py on lines 389..392

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method edit has 131 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function edit() {
        // Allow extensions to modify/prevent this form or submission
        if ( !$this->getHookRunner()->onAlternateEdit( $this ) ) {
            return;
        }
Severity: Major
Found in includes/editpage/EditPage.php - About 5 hrs to fix

    Method buildNavUrls has 131 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function buildNavUrls() {
        $out = $this->getOutput();
        $title = $this->getTitle();
        $thispage = $title->getPrefixedDBkey();
        $uploadNavigationUrl = $this->getConfig()->get( MainConfigNames::UploadNavigationUrl );
    Severity: Major
    Found in includes/skins/Skin.php - About 5 hrs to fix

      Method checkSettings has 131 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function checkSettings(
        ApiBase $module, array $params, string $name, array $options
    ): array {
        $options['module'] = $module;
        $settings = $params[$name];
      Severity: Major
      Found in includes/api/Validator/ApiParamValidator.php - About 5 hrs to fix

        Method execute has 131 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function execute() {
        $db = $this->getDB();
        $params = $this->extractRequestParams();
        $this->requireMaxOneParameter( $params, 'group', 'excludegroup', 'rights', 'excluderights' );
        Severity: Major
        Found in includes/api/ApiQueryContributors.php - About 5 hrs to fix

          Method extractDeprecatedContent has 131 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function extractDeprecatedContent( Content $content, RevisionRecord $revision ) {
        $vals = [];
        $title = Title::newFromLinkTarget( $revision->getPageAsLinkTarget() );

        if ( $this->fld_parsetree || ( $this->fld_content && $this->generateXML ) ) {
          Severity: Major
          Found in includes/api/ApiQueryRevisionsBase.php - About 5 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            $dateFormats = [
    /*
    'Није битно',
    '06:12, 5. јануар 2001.',
    '06:12, 5 јануар 2001',
            Severity: Major
            Found in languages/messages/MessagesSr_el.php and 1 other location - About 5 hrs to fix
            languages/messages/MessagesSr_ec.php on lines 244..299

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 188.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            $dateFormats = [
    /*
    'Није битно',
    '06:12, 5. јануар 2001.',
    '06:12, 5 јануар 2001',
            Severity: Major
            Found in languages/messages/MessagesSr_ec.php and 1 other location - About 5 hrs to fix
            languages/messages/MessagesSr_el.php on lines 241..296

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 188.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function __construct() {
        parent::__construct();
        $this->addDescription( 'Run a file or dump with several parsers' );
        $this->addOption( 'parser1', 'The first parser to compare.', true, true );
        $this->addOption( 'parser2', 'The second parser to compare.', true, true );
            Severity: Major
            Found in maintenance/compareParsers.php and 1 other location - About 5 hrs to fix
            maintenance/runJobs.php on lines 38..48

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 188.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function __construct() {
        parent::__construct();
        $this->addDescription( 'Run pending jobs' );
        $this->addOption( 'maxjobs', 'Maximum number of jobs to run', false, true );
        $this->addOption( 'maxtime', 'Maximum amount of wall-clock time', false, true );
            Severity: Major
            Found in maintenance/runJobs.php and 1 other location - About 5 hrs to fix
            maintenance/compareParsers.php on lines 63..93

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 188.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File SpecialImport.php has 384 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
/**
 * Copyright © 2003,2005 Brooke Vibber <bvibber@wikimedia.org>
 * https://www.mediawiki.org/
 *
            Severity: Minor
            Found in includes/specials/SpecialImport.php - About 5 hrs to fix

              Function addDevtools has 130 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function addDevtools (app, store) {
    setupDevtoolsPlugin(
      {
        id: 'org.vuejs.vuex',
        app: app,
              Severity: Major
              Found in resources/lib/vuex/vuex.global.js - About 5 hrs to fix

                Method setVisibility has 130 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function setVisibility( array $params ) {
        $status = Status::newGood();

        $bitPars = $params['value'];
        $comment = $params['comment'];
                Severity: Major
                Found in includes/revisiondelete/RevDelList.php - About 5 hrs to fix

                  Method execute has 130 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function execute() {
        // If we're in a mode that breaks the same-origin policy, no tokens can
        // be obtained
        if ( $this->lacksSameOriginSecurity() ) {
            $this->getResult()->addValue( null, 'login', [
                  Severity: Major
                  Found in includes/api/ApiLogin.php - About 5 hrs to fix

                    File ExtensionRegistry.php has 382 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php

namespace MediaWiki\Registration;

use AutoLoader;
                    Severity: Minor
                    Found in includes/registration/ExtensionRegistry.php - About 5 hrs to fix

                      File Router.php has 382 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php

namespace MediaWiki\Rest;

use HttpStatus;
                      Severity: Minor
                      Found in includes/Rest/Router.php - About 5 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language