Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star

Showing 11,545 of 11,545 total issues

Method execute has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        $user = $this->getUser();
        $params = $this->extractRequestParams();

        if ( $user->isBot() ) {
Severity: Major
Found in includes/api/ApiStashEdit.php - About 4 hrs to fix

    Method formatRow has 103 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function formatRow( $row ) {
        $title = Title::newFromRow( $row );

        // Revision deletion works on revisions,
        // so cast our recent change row to a revision row.
    Severity: Major
    Found in includes/specials/pagers/NewPagesPager.php - About 4 hrs to fix

      Method doMoveToExternal has 103 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function doMoveToExternal() {
        $success = true;
        $dbr = $this->getReplicaDB();

        $count = $this->maxID - $this->minID + 1;
      Severity: Major
      Found in maintenance/storage/moveToExternal.php - About 4 hrs to fix

        Method generateFirstChars has 103 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function generateFirstChars() {
        $file = fopen( "{$this->dataDir}/allkeys.txt", 'r' );
        if ( !$file ) {
            $this->fatalError( "Unable to open allkeys.txt" );
        }
        Severity: Major
        Found in maintenance/language/generateCollationData.php - About 4 hrs to fix

          File CommentParser.php has 338 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php

namespace MediaWiki\CommentFormatter;

use File;
          Severity: Minor
          Found in includes/CommentFormatter/CommentParser.php - About 4 hrs to fix

            File SpecialEditTags.php has 338 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
            Severity: Minor
            Found in includes/specials/SpecialEditTags.php - About 4 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              mw.widgets.TableWidget.prototype.addItems = function ( items, index ) {
    let i, len;

    OO.ui.mixin.GroupElement.prototype.addItems.call( this, items, index );
              Severity: Major
              Found in resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js and 1 other location - About 4 hrs to fix
              resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js on lines 124..132

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  _stop: function( event, index ) {
        var uiHash = {
            handle: this.handles[ index ],
            value: this.value()
        };
              Severity: Major
              Found in resources/lib/jquery.ui/jquery.ui.slider.js and 1 other location - About 4 hrs to fix
              resources/lib/jquery.ui/jquery.ui.slider.js on lines 412..423

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              mw.widgets.RowWidget.prototype.addItems = function ( items, index ) {
    let i, len;

    OO.ui.mixin.GroupElement.prototype.addItems.call( this, items, index );
              Severity: Major
              Found in resources/src/mediawiki.widgets/Table/mw.widgets.RowWidget.js and 1 other location - About 4 hrs to fix
              resources/src/mediawiki.widgets/Table/mw.widgets.TableWidget.js on lines 287..295

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( !this._keySliding && !this._mouseSliding ) {
            var uiHash = {
                handle: this.handles[ index ],
                value: this.value()
            };
              Severity: Major
              Found in resources/lib/jquery.ui/jquery.ui.slider.js and 1 other location - About 4 hrs to fix
              resources/lib/jquery.ui/jquery.ui.slider.js on lines 398..409

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              File PageEditStash.php has 337 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
              Severity: Minor
              Found in includes/Storage/PageEditStash.php - About 4 hrs to fix

                File BacklinkCache.php has 337 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
/**
 * Class for fetching backlink lists, approximate backlink counts and
 * partitions.
 *
                Severity: Minor
                Found in includes/cache/BacklinkCache.php - About 4 hrs to fix

                  File LinkFilter.php has 337 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
                  Severity: Minor
                  Found in includes/ExternalLinks/LinkFilter.php - About 4 hrs to fix

                    Function useButtonGroupKeyboardNav has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function useButtonGroupKeyboardNav(buttonsProp) {
  const rootElement = ref();
  const focusedButtonIndex = ref();
  const buttonRefs = ref(/* @__PURE__ */ new Map());
  const currentDirection = useComputedDirection(rootElement);
                    Severity: Minor
                    Found in resources/lib/codex/codex.js - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function respond has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function respond( Context $context ) {
        // Buffer output to catch warnings. Normally we'd use ob_clean() on the
        // top-level output buffer to clear warnings, but that breaks when ob_gzhandler
        // is used: ob_clean() will clear the GZIP header in that case and it won't come
        // back for subsequent output, resulting in invalid GZIP. So we have to wrap
                    Severity: Minor
                    Found in includes/ResourceLoader/ResourceLoader.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function normalizeHandler has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function normalizeHandler( string $hook, $handler, array $options = [] ) {
        if ( is_object( $handler ) && !$handler instanceof Closure ) {
            $handler = [ $handler, $this->getHookMethodName( $hook ) ];
        }
                    Severity: Minor
                    Found in includes/HookContainer/HookContainer.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function extractInfo has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function extractInfo( $path, array $info, $version ) {
        $dir = dirname( $path );
        $this->extractHooks( $info, $path );
        $this->extractExtensionMessagesFiles( $dir, $info );
        $this->extractRestModuleFiles( $dir, $info );
                    Severity: Minor
                    Found in includes/registration/ExtensionProcessor.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getDiffBody has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getDiffBody() {
        $this->mCacheHit = true;
        // Check if the diff should be hidden from this user
        if ( !$this->isContentOverridden ) {
            if ( !$this->loadRevisionData() ) {
                    Severity: Minor
                    Found in includes/diff/DifferenceEngine.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function validateValue has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function validateValue( $name, $value, $settings, array $options = [] ) {
        $settings = $this->normalizeSettings( $settings );

        $typeDef = $this->getTypeDef( $settings[self::PARAM_TYPE] );
        if ( !$typeDef ) {
                    Severity: Minor
                    Found in includes/libs/ParamValidator/ParamValidator.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getSlotRowsForBatch has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function getSlotRowsForBatch(
        $rowsOrIds,
        array $options = [],
        $queryFlags = 0
    ) {
                    Severity: Minor
                    Found in includes/Revision/RevisionStore.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language