wikimedia/mediawiki-core

Method `getCount` has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getCount( $type ) {
        $pageId = $this->getPage()->getId();
        switch ( $type ) {
            case 'anonymous':
                return $this->getCachedCount( $type,

Found in includes/Rest/Handler/PageHistoryCountHandler.php - About 3 hrs to fix

File `jquery.i18n.fallbacks.js` has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery Internationalization library
 *
 * Copyright (C) 2012 Santhosh Thottingal
 *

Found in resources/lib/jquery.i18n/src/jquery.i18n.fallbacks.js - About 3 hrs to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function __construct( $msg, $code = null, array $data = null ) {
        if ( $msg instanceof Message ) {
            foreach ( get_class_vars( get_class( $this ) ) as $key => $value ) {
                if ( isset( $msg->$key ) ) {
                    $this->$key = $msg->$key;

Found in includes/api/ApiMessage.php and 1 other location - About 3 hrs to fix

Read up
Read up

includes/api/ApiRawMessage.php on lines 43..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function __construct( $msg, $code = null, array $data = null ) {
        if ( $msg instanceof RawMessage ) {
            foreach ( get_class_vars( get_class( $this ) ) as $key => $value ) {
                if ( isset( $msg->$key ) ) {
                    $this->$key = $msg->$key;

Found in includes/api/ApiRawMessage.php and 1 other location - About 3 hrs to fix

Read up
Read up

includes/api/ApiMessage.php on lines 79..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `setup` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  setup: (props, { emit, attrs, slots }) => {
    const rootElement = ref();
    const textInput = ref();
    const menu = ref();
    const menuId = useGeneratedId("lookup-menu");

Found in resources/lib/codex/codex.js - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `actuallyNotifyOnPageChange` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function actuallyNotifyOnPageChange(
        Authority $editor,
        $title,
        $timestamp,
        $summary,

Found in includes/mail/EmailNotification.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `writeSlot` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    private function writeSlot( SlotRecord $slot, $contentMode ) {
        $isMain = $slot->getRole() === SlotRecord::MAIN;
        $isV11 = $this->schemaVersion >= XML_DUMP_SCHEMA_VERSION_11;

        if ( !$isV11 && !$isMain ) {

Found in includes/export/XmlDumpWriter.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `normalizeContents` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    protected function normalizeContents(
        Content &$oldContent = null, Content &$newContent = null, $allowedClasses = null
    ) {
        if ( !$oldContent && !$newContent ) {
            throw new InvalidArgumentException( '$oldContent and $newContent cannot both be null' );

Found in includes/diff/SlotDiffRenderer.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `loadRevisionData` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadRevisionData() {
        if ( $this->mRevisionsLoaded ) {
            return $this->isContentOverridden ||
            ( $this->mOldRevisionRecord !== null && $this->mNewRevisionRecord !== null );
        }

Found in includes/diff/DifferenceEngine.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `checkCache` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function checkCache( PageIdentity $page, Content $content, UserIdentity $user ) {
        $legacyUser = $this->userFactory->newFromUserIdentity( $user );
        if (
            // The context is not an HTTP POST request
            !$legacyUser->getRequest()->wasPosted() ||

Found in includes/Storage/PageEditStash.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `detectNonSerializableDataInternal` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    private function detectNonSerializableDataInternal(
        $value,
        bool $expectDeserialize,
        string $accumulatedPath,
        bool $exhaustive = false

Found in includes/json/JsonCodec.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `delimiterReplaceCallback` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    private static function delimiterReplaceCallback( $startDelim, $endDelim, $callback,
        $subject, $flags = ''
    ) {
        $inputPos = 0;
        $outputPos = 0;

Found in includes/libs/StringUtils.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `arrayDiffAssocRecursive` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public static function arrayDiffAssocRecursive( $array1, ...$arrays ) {
        $ret = [];

        foreach ( $array1 as $key => $value ) {
            if ( is_array( $value ) ) {

Found in includes/libs/ArrayUtils.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `recordQueryCompletion` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function recordQueryCompletion(
        $query,
        float $sTime,
        bool $isWrite,
        ?int $rowCount,

Found in includes/libs/rdbms/TransactionProfiler.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `closePrinter` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function closePrinter() {
        if ( $this->mDisabled ) {
            return;
        }

Found in includes/api/ApiFormatBase.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `execute` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute( $par ) {
        $this->useTransactionalTimeLimit();

        $user = $this->getUser();

Found in includes/specials/SpecialUndelete.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `getJSVars` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function getJSVars( ?int $flag = null ) {
        $curRevisionId = 0;
        $articleId = 0;
        $canonicalSpecialPageName = false; # T23115
        $services = MediaWikiServices::getInstance();

Found in includes/Output/OutputPage.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `getParametersForApi` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getParametersForApi() {
        $entry = $this->entry;
        $params = [];

        $subtype = $this->entry->getSubtype();

Found in includes/logging/DeleteLogFormatter.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `getShowHideLinks` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    private function getShowHideLinks( $row ) {
        // We don't want to see the links and
        if ( $this->flags == self::NO_ACTION_LINK ) {
            return '';
        }

Found in includes/logging/LogEventsList.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `execute` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(): Response {
        $request = $this->getRequest();
        $from = $request->getPathParam( 'from' );
        $format = $request->getPathParam( 'format' );

Found in includes/Rest/Handler/TransformHandler.php - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading