Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/BaseInterwikiResolver.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method sendConfigDumpRequest has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function sendConfigDumpRequest( $endpoints ) {
        $logger = LoggerFactory::getInstance( 'CirrusSearch' );
        $reqs = [];
        foreach ( $endpoints as $prefix => $info ) {
            $reqs[$prefix] = [
Severity: Major
Found in includes/BaseInterwikiResolver.php - About 2 hrs to fix

    Function loadConfigFromAPI has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        private function loadConfigFromAPI( $wikis, array $hashConfigFlags, $fallbackConfig ) {
        $endpoints = [];
        foreach ( $wikis as $prefix => $wiki ) {
            $iw = $this->interwikiLookup->fetch( $prefix );
            if ( !$iw || !$this->useConfigDumpApi || !$iw->isLocal() ) {
    Severity: Minor
    Found in includes/BaseInterwikiResolver.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method loadConfigFromAPI has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function loadConfigFromAPI( $wikis, array $hashConfigFlags, $fallbackConfig ) {
        $endpoints = [];
        foreach ( $wikis as $prefix => $wiki ) {
            $iw = $this->interwikiLookup->fetch( $prefix );
            if ( !$iw || !$this->useConfigDumpApi || !$iw->isLocal() ) {
    Severity: Minor
    Found in includes/BaseInterwikiResolver.php - About 1 hr to fix

      Function sendConfigDumpRequest has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function sendConfigDumpRequest( $endpoints ) {
        $logger = LoggerFactory::getInstance( 'CirrusSearch' );
        $reqs = [];
        foreach ( $endpoints as $prefix => $info ) {
            $reqs[$prefix] = [
      Severity: Minor
      Found in includes/BaseInterwikiResolver.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status