Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/BuildDocument/Completion/SuggestBuilder.php

Summary

Maintainability
D
1 day
Test Coverage

Function build has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

    public function build( $inputDocs, $explain = false ) {
        $titleFactory = MediaWikiServices::getInstance()->getTitleFactory();
        // Cross namespace titles
        $crossNsTitles = [];
        $docs = [];
Severity: Minor
Found in includes/BuildDocument/Completion/SuggestBuilder.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File SuggestBuilder.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace CirrusSearch\BuildDocument\Completion;

use CirrusSearch\Connection;
Severity: Minor
Found in includes/BuildDocument/Completion/SuggestBuilder.php - About 2 hrs to fix

    Method build has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function build( $inputDocs, $explain = false ) {
        $titleFactory = MediaWikiServices::getInstance()->getTitleFactory();
        // Cross namespace titles
        $crossNsTitles = [];
        $docs = [];
    Severity: Major
    Found in includes/BuildDocument/Completion/SuggestBuilder.php - About 2 hrs to fix

      Function extractSimilars has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          private function extractSimilars( $groupHead, array $candidates, $checkVariants = false ) {
        $group = [
            'text' => $groupHead,
            'variants' => []
        ];
      Severity: Minor
      Found in includes/BuildDocument/Completion/SuggestBuilder.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method buildSuggestion has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private function buildSuggestion( $suggestionType, $docId, array $inputs, $score, array $inputDoc, array $scoreExplanation = null ) {
      Severity: Minor
      Found in includes/BuildDocument/Completion/SuggestBuilder.php - About 45 mins to fix

        Method buildRedirectsSuggestion has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function buildRedirectsSuggestion( $docId, array $redirects, $score, array $inputDoc, array $scoreExplanation = null ) {
        Severity: Minor
        Found in includes/BuildDocument/Completion/SuggestBuilder.php - About 35 mins to fix

          Method buildTitleSuggestion has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function buildTitleSuggestion( $docId, array $title, $score, array $inputDoc, array $scoreExplanation = null ) {
          Severity: Minor
          Found in includes/BuildDocument/Completion/SuggestBuilder.php - About 35 mins to fix

            Function extractTitleAndSimilarRedirects has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function extractTitleAndSimilarRedirects( array $doc ) {
        $redirects = [];
        if ( isset( $doc['redirect'] ) ) {
            foreach ( $doc['redirect'] as $redir ) {
                // Avoid suggesting/displaying non existent titles
            Severity: Minor
            Found in includes/BuildDocument/Completion/SuggestBuilder.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status