Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/CompletionSuggester.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method suggest has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function suggest( $text, $variants = null ) {
        $suggestSearch = $this->getSuggestSearchRequest( $text, $variants );
        $mSearchRequests = new MSearchRequests();

        if ( $suggestSearch !== null ) {
Severity: Minor
Found in includes/CompletionSuggester.php - About 1 hr to fix

    Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct( Connection $conn, $limit, $offset = 0, SearchConfig $config = null, array $namespaces = null,
        User $user = null, $index = false, $profileName = null,
                                 CirrusDebugOptions $debugOptions = null ) {
    Severity: Major
    Found in includes/CompletionSuggester.php - About 1 hr to fix

      Function collectPrefixSearchResults has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function collectPrefixSearchResults( CompletionResultsCollector $collector, array $results, CompletionRequestLog $log ) {
        if ( !isset( $results[self::MSEARCH_KEY_PREFIX] ) ) {
            return 0;
        }
        $indexName = $this->prefixSearchRequestBuilder->getIndex()->getName();
      Severity: Minor
      Found in includes/CompletionSuggester.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getPrefixSearchRequest has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getPrefixSearchRequest( $term, $variants ) {
        $namespaces = $this->searchContext->getNamespaces();
        if ( $namespaces === null ) {
            return null;
        }
      Severity: Minor
      Found in includes/CompletionSuggester.php - About 1 hr to fix

        Method collectPrefixSearchResults has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function collectPrefixSearchResults( CompletionResultsCollector $collector, array $results, CompletionRequestLog $log ) {
        if ( !isset( $results[self::MSEARCH_KEY_PREFIX] ) ) {
            return 0;
        }
        $indexName = $this->prefixSearchRequestBuilder->getIndex()->getName();
        Severity: Minor
        Found in includes/CompletionSuggester.php - About 1 hr to fix

          Function getPrefixSearchRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getPrefixSearchRequest( $term, $variants ) {
        $namespaces = $this->searchContext->getNamespaces();
        if ( $namespaces === null ) {
            return null;
        }
          Severity: Minor
          Found in includes/CompletionSuggester.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return $status;
          Severity: Major
          Found in includes/CompletionSuggester.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $this->prefixSearchRequestBuilder->setLimit( $limit )
            // collect all results up to $limit, $this->offset is the offset the client wants
            // not the offset in prefix search results.
            ->setOffset( 0 )
            ->build();
            Severity: Major
            Found in includes/CompletionSuggester.php - About 30 mins to fix

              Function suggest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function suggest( $text, $variants = null ) {
        $suggestSearch = $this->getSuggestSearchRequest( $text, $variants );
        $mSearchRequests = new MSearchRequests();

        if ( $suggestSearch !== null ) {
              Severity: Minor
              Found in includes/CompletionSuggester.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status