Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Elastica/ReindexTask.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method mergeStatusWithChildren has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function mergeStatusWithChildren( array $status, array $childResponse ) {
        foreach ( $childResponse['nodes'] as $nodeData ) {
            foreach ( $nodeData['tasks'] as $taskId => $childData ) {
                $sliceId = $childData['status']['slice_id'];
                $status['slices'][$sliceId] = $childData['status'];
Severity: Major
Found in includes/Elastica/ReindexTask.php - About 2 hrs to fix

    Function mergeStatusWithChildren has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        private function mergeStatusWithChildren( array $status, array $childResponse ) {
        foreach ( $childResponse['nodes'] as $nodeData ) {
            foreach ( $nodeData['tasks'] as $taskId => $childData ) {
                $sliceId = $childData['status']['slice_id'];
                $status['slices'][$sliceId] = $childData['status'];
    Severity: Minor
    Found in includes/Elastica/ReindexTask.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getStatus has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getStatus() {
        if ( $this->response ) {
            // task complete
            return $this->response;
        }
    Severity: Minor
    Found in includes/Elastica/ReindexTask.php - About 1 hr to fix

      Function getStatus has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getStatus() {
        if ( $this->response ) {
            // task complete
            return $this->response;
        }
      Severity: Minor
      Found in includes/Elastica/ReindexTask.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status