Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Fallbacks/FallbackRunner.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function run(
        SearcherFactory $factory,
        CirrusSearchResultSet $initialResult,
        MSearchResponses $responses,
        NamespacePrefixParser $namespacePrefixParser,
Severity: Minor
Found in includes/Fallbacks/FallbackRunner.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run(
        SearcherFactory $factory,
        CirrusSearchResultSet $initialResult,
        MSearchResponses $responses,
        NamespacePrefixParser $namespacePrefixParser,
Severity: Minor
Found in includes/Fallbacks/FallbackRunner.php - About 1 hr to fix

    Function getElasticSuggesters has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getElasticSuggesters(): array {
        $suggesters = [];
        foreach ( $this->fallbackMethods as $method ) {
            if ( $method instanceof ElasticSearchSuggestFallbackMethod ) {
                $suggestQueries = $method->getSuggestQueries();
    Severity: Minor
    Found in includes/Fallbacks/FallbackRunner.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createFromProfile has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function createFromProfile( SearchQuery $query, array $profile, InterwikiResolver $interwikiResolver ): FallbackRunner {
        $fallbackMethods = [];
        $methodDefs = $profile['methods'] ?? [];
        foreach ( $methodDefs as $name => $methodDef ) {
            if ( !isset( $methodDef['class'] ) ) {
    Severity: Minor
    Found in includes/Fallbacks/FallbackRunner.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            SearcherFactory $factory,
        CirrusSearchResultSet $initialResult,
        MSearchResponses $responses,
        NamespacePrefixParser $namespacePrefixParser,
        CirrusSearchHookRunner $cirrusSearchHookRunner
    Severity: Minor
    Found in includes/Fallbacks/FallbackRunner.php - About 35 mins to fix

      Function attachSearchRequests has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function attachSearchRequests( MSearchRequests $requests, Client $client ) {
        $position = 0;
        foreach ( $this->fallbackMethods as $method ) {
            $position++;
            if ( $method instanceof ElasticSearchRequestFallbackMethod ) {
      Severity: Minor
      Found in includes/Fallbacks/FallbackRunner.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status