Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Job/ElasticaWrite.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method doJob has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function doJob() {
        // While we can only have a single connection per job, we still
        // use decideClusters() which includes a variety of safeguards.
        $connections = $this->decideClusters( $this->params['update_group'] );
        if ( !$connections ) {
Severity: Minor
Found in includes/Job/ElasticaWrite.php - About 1 hr to fix

    Function serde has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function serde( $method, array $arguments, $serialize = true ) {
        if ( isset( self::$SERDE[$method] ) ) {
            foreach ( self::$SERDE[$method] as $i => $serde ) {
                if ( $serde !== null && array_key_exists( $i, $arguments ) ) {
                    $impl = new $serde();
    Severity: Minor
    Found in includes/Job/ElasticaWrite.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method requeueError has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function requeueError( Connection $conn ) {
        if ( $this->params['errorCount'] >= self::MAX_ERROR_RETRY ) {
            LoggerFactory::getInstance( 'CirrusSearchChangeFailed' )->warning(
                "Dropping failing ElasticaWrite job for DataSender::{method} in cluster {cluster} after repeated failure",
                [
    Severity: Minor
    Found in includes/Job/ElasticaWrite.php - About 1 hr to fix

      Method build has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ClusterSettings $cluster,
        string $updateGroup,
        string $method,
        array $arguments,
        array $params = [],
      Severity: Major
      Found in includes/Job/ElasticaWrite.php - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status