Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Maintenance/ChunkBuilder.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function build has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function build( $self, array $options, $buildChunks, $fromPageId, $toPageId ) {
        $fixedChunkSize = strpos( $buildChunks, 'total' ) === false;
        $buildChunks = intval( $buildChunks );
        if ( $fixedChunkSize ) {
            $chunkSize = $buildChunks;
Severity: Minor
Found in includes/Maintenance/ChunkBuilder.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

                if ( $optVal === null || $optVal === false || $optName === 'fromId' ||
                    $optName === 'toId' || $optName === 'buildChunks' ||
                    ( $optName === 'memory-limit' && $optVal === 'max' )
                ) {
                    continue;
Severity: Major
Found in includes/Maintenance/ChunkBuilder.php - About 1 hr to fix

    Method build has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function build( $self, array $options, $buildChunks, $fromPageId, $toPageId ) {
    Severity: Minor
    Found in includes/Maintenance/ChunkBuilder.php - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status