includes/Maintenance/ConfigUtils.php
Function pickIndexIdentifierFromOption has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
public function pickIndexIdentifierFromOption( $option, $typeName ): Status {
if ( $option === 'now' ) {
$identifier = strval( time() );
$this->outputIndented( "Setting index identifier...{$typeName}_{$identifier}\n" );
return Status::newGood( $identifier );- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method pickIndexIdentifierFromOption has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function pickIndexIdentifierFromOption( $option, $typeName ): Status {
if ( $option === 'now' ) {
$identifier = strval( time() );
$this->outputIndented( "Setting index identifier...{$typeName}_{$identifier}\n" );
return Status::newGood( $identifier );Method isIndexLive has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function isIndexLive( $indexName ): Status {
try {
// primary check, verify no aliases point at our index. This invokes
// the endpoint directly, rather than Index::getAliases, as that method
// does not check http status codes and can incorrectly report no aliases.Function isIndexLive has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
public function isIndexLive( $indexName ): Status {
try {
// primary check, verify no aliases point at our index. This invokes
// the endpoint directly, rather than Index::getAliases, as that method
// does not check http status codes and can incorrectly report no aliases.- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
Open
return Status::newGood( $option );Avoid too many return statements within this method. Open
Open
return Status::newGood( false );Avoid too many return statements within this method. Open
Open
return $status;