Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Maintenance/GlobalCustomFilter.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function enableGlobalCustomFilters has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public static function enableGlobalCustomFilters( array $config, string $language,
            array $customFilters, array $installedPlugins ) {
        foreach ( $customFilters as $filterName => $gcfInfo ) {
            if ( !$gcfInfo->languageCheck( $language ) ) {
                continue;
Severity: Minor
Found in includes/Maintenance/GlobalCustomFilter.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if ( !array_key_exists( $analyzer, $config['analyzer'] ) // array exists
            || $config['analyzer'][$analyzer]['type'] != 'custom' // array is custom
            || !$this->requiredTokenizerUsed( $config['analyzer'][$analyzer] )
            || $this->disallowedTokenFiltersPresent( $config, $analyzer )
            || $this->disallowedCharFiltersPresent( $config, $analyzer )
Severity: Major
Found in includes/Maintenance/GlobalCustomFilter.php - About 40 mins to fix

    There are no issues that match your filters.

    Category
    Status