Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Maintenance/MappingConfigBuilder.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method getDefaultFields has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getDefaultFields() {
        // Note never to set something as type='object' here because that isn't returned by elasticsearch
        // and is inferred anyway.
        $titleExtraAnalyzers = [
            [ 'analyzer' => 'prefix', 'search_analyzer' => 'near_match', 'index_options' => 'docs', 'norms' => false ],
Severity: Major
Found in includes/Maintenance/MappingConfigBuilder.php - About 4 hrs to fix

    Method buildConfig has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function buildConfig() {
        global $wgCirrusSearchWeights;

        $page = $this->getDefaultFields();
    Severity: Minor
    Found in includes/Maintenance/MappingConfigBuilder.php - About 1 hr to fix

      Function setupCopyTo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function setupCopyTo( $config, $fields, $destination ) {
        foreach ( $fields as $field => $weight ) {
            // Note that weights this causes weights that are not whole numbers to be rounded up.
            // We're ok with that because we don't have a choice.
            for ( $r = 0; $r < $weight; $r++ ) {
      Severity: Minor
      Found in includes/Maintenance/MappingConfigBuilder.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function buildConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function buildConfig() {
        global $wgCirrusSearchWeights;

        $page = $this->getDefaultFields();
      Severity: Minor
      Found in includes/Maintenance/MappingConfigBuilder.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status