Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Maintenance/Validators/IndexAliasValidator.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function validate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate(): Status {
        // arrays of aliases to be added/removed
        $add = $remove = [];

        $this->outputIndented( "\tValidating $this->aliasName alias..." );
Severity: Minor
Found in includes/Maintenance/Validators/IndexAliasValidator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate(): Status {
        // arrays of aliases to be added/removed
        $add = $remove = [];

        $this->outputIndented( "\tValidating $this->aliasName alias..." );
Severity: Minor
Found in includes/Maintenance/Validators/IndexAliasValidator.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct( Client $client, $aliasName, $specificIndexName, $startOver, Printer $out ) {
    Severity: Minor
    Found in includes/Maintenance/Validators/IndexAliasValidator.php - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

              return $this->updateIndices( $add, $remove );
      Severity: Major
      Found in includes/Maintenance/Validators/IndexAliasValidator.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status