Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/NearMatchPicker.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function pickBest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function pickBest() {
        if ( !$this->titles ) {
            return null;
        }
        if ( !$this->term ) {
Severity: Minor
Found in includes/NearMatchPicker.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pickBest has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function pickBest() {
        if ( !$this->titles ) {
            return null;
        }
        if ( !$this->term ) {
Severity: Minor
Found in includes/NearMatchPicker.php - About 1 hr to fix

    Function checkAllMatches has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function checkAllMatches( $transformer, $transformedTerm, $allMatchedTitles ) {
        if ( isset( $allMatchedTitles[ 'titleMatch' ] ) &&
                $this->checkOneMatch( $transformer, $transformedTerm, $allMatchedTitles[ 'titleMatch' ] ) ) {
            return $allMatchedTitles[ 'titleMatch' ];
        }
    Severity: Minor
    Found in includes/NearMatchPicker.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return null;
    Severity: Major
    Found in includes/NearMatchPicker.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return null;
      Severity: Major
      Found in includes/NearMatchPicker.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $found;
        Severity: Major
        Found in includes/NearMatchPicker.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $term;
          Severity: Major
          Found in includes/NearMatchPicker.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status