Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Profile/ArrayPathSetter.php

Summary

Maintainability
C
1 day
Test Coverage

Function replace has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    private function replace( array $profile, array $replacement ) {
        $cur = &$profile;
        foreach ( $replacement['matches'] as $match ) {
            if ( !is_array( $cur ) ) {
                return $profile;
Severity: Minor
Found in includes/Profile/ArrayPathSetter.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method replace has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function replace( array $profile, array $replacement ) {
        $cur = &$profile;
        foreach ( $replacement['matches'] as $match ) {
            if ( !is_array( $cur ) ) {
                return $profile;
Severity: Minor
Found in includes/Profile/ArrayPathSetter.php - About 1 hr to fix

    Function getCompiledReplacements has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getCompiledReplacements() {
        if ( $this->compiledReplacements === null ) {
            $this->compiledReplacements = [];
            foreach ( $this->replacements as $repl => $value ) {
                if ( !is_string( $repl ) ) {
    Severity: Minor
    Found in includes/Profile/ArrayPathSetter.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getCompiledReplacements has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getCompiledReplacements() {
        if ( $this->compiledReplacements === null ) {
            $this->compiledReplacements = [];
            foreach ( $this->replacements as $repl => $value ) {
                if ( !is_string( $repl ) ) {
    Severity: Minor
    Found in includes/Profile/ArrayPathSetter.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status