Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Profile/SearchProfileService.php

Summary

Maintainability
B
6 hrs
Test Coverage

SearchProfileService has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class SearchProfileService {

    /**
     * Profile type for ordering crossproject result blocks
     */
Severity: Minor
Found in includes/Profile/SearchProfileService.php - About 2 hrs to fix

    Function listExposedProfiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function listExposedProfiles( $type ) {
        $profiles = [];
        if ( isset( $this->repositories[$type] ) ) {
            foreach ( $this->repositories[$type] as $repo ) {
                foreach ( $repo->listExposedProfiles() as $name => $profile ) {
    Severity: Minor
    Found in includes/Profile/SearchProfileService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getProfileName has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getProfileName( $type, $context = self::CONTEXT_DEFAULT, array $contextParams = [] ) {
        $minPrio = PHP_INT_MAX;
        if ( !isset( $this->defaultProfiles[$type][$context] ) ) {
            throw new SearchProfileException( "No default profile found for $type in context $context" );
        }
    Severity: Minor
    Found in includes/Profile/SearchProfileService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loadProfileByName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function loadProfileByName( $type, $name, $failIfMissing = true ) {
        if ( isset( $this->repositories[$type] ) ) {
            $repos = $this->repositories[$type];
            foreach ( $repos as $repo ) {
                $prof = $repo->getProfile( $name );
    Severity: Minor
    Found in includes/Profile/SearchProfileService.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function hasProfile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function hasProfile( $type, $name ) {
        if ( isset( $this->repositories[$type] ) ) {
            foreach ( $this->repositories[$type] as $repo ) {
                if ( $repo->hasProfile( $name ) ) {
                    return true;
    Severity: Minor
    Found in includes/Profile/SearchProfileService.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status