Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Query/BaseRegexFeature.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method buildRegexWithGroovy has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildRegexWithGroovy( $pattern, $insensitive ) {
        $filters = [];
        foreach ( $this->fields as $field ) {
            $script = <<<GROOVY
import org.apache.lucene.util.automaton.*;
Severity: Minor
Found in includes/Query/BaseRegexFeature.php - About 1 hr to fix

    Method doApplyExtended has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function doApplyExtended( SearchContext $context, $key, $value, $quotedValue, $negated, $delimiter, $suffix ) {
    Severity: Major
    Found in includes/Query/BaseRegexFeature.php - About 50 mins to fix

      Method parseValue has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function parseValue( $key, $value, $quotedValue, $valueDelimiter, $suffix, WarningCollector $warningCollector ) {
      Severity: Minor
      Found in includes/Query/BaseRegexFeature.php - About 45 mins to fix

        Function doApplyExtended has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function doApplyExtended( SearchContext $context, $key, $value, $quotedValue, $negated, $delimiter, $suffix ) {
        $parsedValue = $this->parseValue( $key, $value, $quotedValue, $delimiter, $suffix, $context );
        if ( $this->isRegexQuery( $parsedValue ) ) {
            if ( !$this->enabled ) {
                return [ null, false ];
        Severity: Minor
        Found in includes/Query/BaseRegexFeature.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildRegexWithPlugin has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function buildRegexWithPlugin( $pattern, $insensitive ) {
        $filters = [];
        // TODO: Update plugin to accept multiple values for the field property
        // so that at index time we can create a single trigram index with
        // copy_to instead of creating multiple queries.
        Severity: Minor
        Found in includes/Query/BaseRegexFeature.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status