Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Query/FullTextSimpleMatchQueryBuilder.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function buildExpQuery has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    private function buildExpQuery( $queryString ) {
        $query = new \Elastica\Query\BoolQuery();
        $query->setMinimumShouldMatch( 0 );
        $this->attachFilter( $this->filter, $queryString, $query );
        $dismaxQueries = [];
Severity: Minor
Found in includes/Query/FullTextSimpleMatchQueryBuilder.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buildExpQuery has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildExpQuery( $queryString ) {
        $query = new \Elastica\Query\BoolQuery();
        $query->setMinimumShouldMatch( 0 );
        $this->attachFilter( $this->filter, $queryString, $query );
        $dismaxQueries = [];
Severity: Major
Found in includes/Query/FullTextSimpleMatchQueryBuilder.php - About 2 hrs to fix

    Function buildSimpleAllFilter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function buildSimpleAllFilter( $options, $query ) {
        $filter = new \Elastica\Query\BoolQuery();
        $filter->setMinimumShouldMatch( 1 );
        // FIXME: We can't use solely the stem field here
        // - Depending on languages it may lack stopwords,
    Severity: Minor
    Found in includes/Query/FullTextSimpleMatchQueryBuilder.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status