Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Query/HasTemplateFeature.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method parseValue has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function parseValue( $key, $value, $quotedValue, $valueDelimiter, $suffix, WarningCollector $warningCollector ) {
        $values = explode( '|', $value, self::MAX_CONDITIONS + 1 );
        if ( count( $values ) > self::MAX_CONDITIONS ) {
            $warningCollector->addWarning(
                'cirrussearch-feature-too-many-conditions',
Severity: Minor
Found in includes/Query/HasTemplateFeature.php - About 1 hr to fix

    Function parseValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function parseValue( $key, $value, $quotedValue, $valueDelimiter, $suffix, WarningCollector $warningCollector ) {
        $values = explode( '|', $value, self::MAX_CONDITIONS + 1 );
        if ( count( $values ) > self::MAX_CONDITIONS ) {
            $warningCollector->addWarning(
                'cirrussearch-feature-too-many-conditions',
    Severity: Minor
    Found in includes/Query/HasTemplateFeature.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method doApplyExtended has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function doApplyExtended( SearchContext $context, $key, $value, $quotedValue, $negated,
        $delimiter, $suffix
    Severity: Major
    Found in includes/Query/HasTemplateFeature.php - About 50 mins to fix

      Method parseValue has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function parseValue( $key, $value, $quotedValue, $valueDelimiter, $suffix, WarningCollector $warningCollector ) {
      Severity: Minor
      Found in includes/Query/HasTemplateFeature.php - About 45 mins to fix

        Method doApply has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function doApply( SearchContext $context, $key, $value, $quotedValue, $negated ) {
        Severity: Minor
        Found in includes/Query/HasTemplateFeature.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status