Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Query/PreferRecentFeature.php

Summary

Maintainability
A
1 hr
Test Coverage

Method parseValue has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function parseValue( $key, $value, $quotedValue, $valueDelimiter, $suffix, WarningCollector $warningCollector ) {
Severity: Minor
Found in includes/Query/PreferRecentFeature.php - About 45 mins to fix

    Method doApply has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function doApply( SearchContext $context, $key, $value, $quotedValue, $negated ) {
    Severity: Minor
    Found in includes/Query/PreferRecentFeature.php - About 35 mins to fix

      Function parseValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function parseValue( $key, $value, $quotedValue, $valueDelimiter, $suffix, WarningCollector $warningCollector ) {
        $matches = [];
        $retValue = [];
        // FIXME: we should probably no longer accept the empty string and simply return false
        // instead of null
      Severity: Minor
      Found in includes/Query/PreferRecentFeature.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status