Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Query/SimpleKeywordFeature.php

Summary

Maintainability
C
1 day
Test Coverage

Method apply has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function apply( SearchContext $context, $term ) {
        $keyListRegex = implode(
            '|',
            array_map(
                static function ( $kw ) {
Severity: Major
Found in includes/Query/SimpleKeywordFeature.php - About 2 hrs to fix

    Function apply has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function apply( SearchContext $context, $term ) {
        $keyListRegex = implode(
            '|',
            array_map(
                static function ( $kw ) {
    Severity: Minor
    Found in includes/Query/SimpleKeywordFeature.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getValueRegex has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getValueRegex() {
        Assert::invariant( $this->hasValue(), __METHOD__ . ' called but hasValue() is false' );
        if ( $this->greedy() ) {
            Assert::precondition( !$this->allowEmptyValue(), "greedy keywords must not accept empty value" );
            // XXX: we ignore value delimiter for greedy keywords
    Severity: Minor
    Found in includes/Query/SimpleKeywordFeature.php - About 1 hr to fix

      Function getValueRegex has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getValueRegex() {
        Assert::invariant( $this->hasValue(), __METHOD__ . ' called but hasValue() is false' );
        if ( $this->greedy() ) {
            Assert::precondition( !$this->allowEmptyValue(), "greedy keywords must not accept empty value" );
            // XXX: we ignore value delimiter for greedy keywords
      Severity: Minor
      Found in includes/Query/SimpleKeywordFeature.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method doApplyExtended has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              SearchContext $context,
        $key,
        $value,
        $quotedValue,
        $negated,
      Severity: Major
      Found in includes/Query/SimpleKeywordFeature.php - About 50 mins to fix

        Method parseValue has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $key,
        $value,
        $quotedValue,
        $valueDelimiter,
        $suffix,
        Severity: Minor
        Found in includes/Query/SimpleKeywordFeature.php - About 45 mins to fix

          Method doApply has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              abstract protected function doApply( SearchContext $context, $key, $value, $quotedValue, $negated );
          Severity: Minor
          Found in includes/Query/SimpleKeywordFeature.php - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        foreach ( $this->getValueDelimiters() as $delimConfig ) {
                Assert::precondition( strlen( $delimConfig['delimiter'] ) === 1,
                    "Value delimiter must be a single byte char" );
                $delim = preg_quote( $delimConfig['delimiter'], '/' );
                $allDelims .= $delim;
            Severity: Major
            Found in includes/Query/SimpleKeywordFeature.php and 1 other location - About 1 hr to fix
            includes/Parser/QueryStringRegex/KeywordParser.php on lines 145..155

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status