Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Search/BaseCirrusSearchResultSet.php

Summary

Maintainability
A
3 hrs
Test Coverage

BaseCirrusSearchResultSet has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class BaseCirrusSearchResultSet extends BaseSearchResultSet implements CirrusSearchResultSet {
    use SearchResultSetTrait;

    /** @var bool */
    private $hasMoreResults = false;
Severity: Minor
Found in includes/Search/BaseCirrusSearchResultSet.php - About 2 hrs to fix

    Function extractResults has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        final public function extractResults() {
        if ( $this->results === null ) {
            $this->results = [];
            $elasticaResults = $this->getElasticaResultSet();
            if ( $elasticaResults !== null ) {
    Severity: Minor
    Found in includes/Search/BaseCirrusSearchResultSet.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status