wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
includes/Search/Escaper.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method fixupWholeQueryString has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fixupWholeQueryString( $string ) {
        $escapeBadSyntax = static function ( $matches ) {
            return preg_replace( '/(?=[^\s\w])/', '\\', $matches[0] );
        };

Severity: Minor
Found in includes/Search/Escaper.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return $string;
    Severity: Major
    Found in includes/Search/Escaper.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return '"\\~' . $matches[ 'trailing' ];
      Severity: Major
      Found in includes/Search/Escaper.php - About 30 mins to fix

        Function unbalancedQuotes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function unbalancedQuotes( $text, $from = 0, $to = -1 ) {
                $to = $to < 0 ? strlen( $text ) : $to;
                $inQuote = false;
                $inEscape = false;
                for ( $i = $from; $i < $to; $i++ ) {
        Severity: Minor
        Found in includes/Search/Escaper.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status