Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Search/FancyTitleResultsType.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function transformOneElasticResult has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function transformOneElasticResult( \Elastica\Result $r, array $namespaces = [] ) {
        $title = $this->getTitleHelper()->makeTitle( $r );
        $highlights = $r->getHighlights();
        $resultForTitle = [];
Severity: Minor
Found in includes/Search/FancyTitleResultsType.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method transformOneElasticResult has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function transformOneElasticResult( \Elastica\Result $r, array $namespaces = [] ) {
        $title = $this->getTitleHelper()->makeTitle( $r );
        $highlights = $r->getHighlights();
        $resultForTitle = [];
Severity: Minor
Found in includes/Search/FancyTitleResultsType.php - About 1 hr to fix

    Method getHighlightingConfiguration has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getHighlightingConfiguration( array $extraHighlightFields = [] ) {
        global $wgCirrusSearchUseExperimentalHighlighter;

        if ( $wgCirrusSearchUseExperimentalHighlighter ) {
            // This is much less esoteric then the plain highlighter based
    Severity: Minor
    Found in includes/Search/FancyTitleResultsType.php - About 1 hr to fix

      Function resolveRedirectHighlight has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function resolveRedirectHighlight( \Elastica\Result $r, $redirectTitleString, array $docRedirects, $namespaces ) {
        // The match was against a redirect so we should replace the $title with one that
        // represents the redirect.
        // The first step is to strip the actual highlighting from the title.
        $redirectTitleString = str_replace( [ Searcher::HIGHLIGHT_PRE, Searcher::HIGHLIGHT_POST ],
      Severity: Minor
      Found in includes/Search/FancyTitleResultsType.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status