BaseHighlightedField has 29 functions (exceeds 20 allowed). Consider refactoring. Open
class BaseHighlightedField extends HighlightedField {
public const TYPE = 'highlighting';
public const FVH_HL_TYPE = 'fvh';
Method toArray has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function toArray() {
$output = [
'type' => $this->highlighterType
];
Function canMerge has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
private function canMerge( BaseHighlightedField $other ) {
if ( $this->highlighterType !== $other->highlighterType ) {
return false;
}
if ( $this->getTarget() !== $other->getTarget() ) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function merge has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function merge( HighlightedField $other ): HighlightedField {
if ( $this->getFieldName() !== $other->getFieldName() ) {
throw new \InvalidArgumentException(
"Rejecting nonsense merge: Refusing to merge two HighlightFields with different field names: " .
"[{$other->getFieldName()}] != [{$this->getFieldName()}]" );- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function toArray has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function toArray() {
$output = [
'type' => $this->highlighterType
];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return false;Avoid too many return statements within this method. Open
return false;Avoid too many return statements within this method. Open
return false;Avoid too many return statements within this method. Open
return true;Avoid too many return statements within this method. Open
return false;