Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Search/Filters.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function unify has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public static function unify( array $mustFilters, array $mustNotFilters ) {
        // We want to make sure that we execute script filters last.  So we do these steps:
        // 1.  Strip script filters from $must and $mustNot.
        // 2.  Unify the non-script filters.
        // 3.  Build a BoolAnd filter out of the script filters if there are any.
Severity: Minor
Found in includes/Search/Filters.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method unify has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function unify( array $mustFilters, array $mustNotFilters ) {
        // We want to make sure that we execute script filters last.  So we do these steps:
        // 1.  Strip script filters from $must and $mustNot.
        // 2.  Unify the non-script filters.
        // 3.  Build a BoolAnd filter out of the script filters if there are any.
Severity: Minor
Found in includes/Search/Filters.php - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status