Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Search/SearchContext.php

Summary

Maintainability
D
2 days
Test Coverage

SearchContext has 63 functions (exceeds 20 allowed). Consider refactoring.
Open

class SearchContext implements WarningCollector, FilterBuilder {
    /**
     * @var SearchConfig
     */
    private $config;
Severity: Major
Found in includes/Search/SearchContext.php - About 1 day to fix

    File SearchContext.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace CirrusSearch\Search;

use CirrusSearch\CirrusDebugOptions;
    Severity: Minor
    Found in includes/Search/SearchContext.php - About 6 hrs to fix

      Method fromSearchQuery has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function fromSearchQuery(
        SearchQuery $query,
        FallbackRunner $fallbackRunner = null,
        CirrusSearchHookRunner $cirrusSearchHookRunner = null
    ): SearchContext {
      Severity: Minor
      Found in includes/Search/SearchContext.php - About 1 hr to fix

        Function getQuery has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getQuery() {
        if ( !$this->nonTextQueries ) {
            $mainQuery = $this->mainQuery ?: new \Elastica\Query\MatchAll();
        } else {
            $mainQuery = new \Elastica\Query\BoolQuery();
        Severity: Minor
        Found in includes/Search/SearchContext.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                SearchConfig $config,
        array $namespaces = null,
        CirrusDebugOptions $options = null,
        FallbackRunner $fallbackRunner = null,
        FetchPhaseConfigBuilder $fetchPhaseConfigBuilder = null,
        Severity: Minor
        Found in includes/Search/SearchContext.php - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status