Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
includes/Search/SearchQuery.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function getNamespaces has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function getNamespaces(): array {
        $additionalRequired = null;
        if ( $this->initialNamespaces != [] && $this->contextualFilters != [] ) {
            foreach ( $this->contextualFilters as $filter ) {
                $additional = $filter->requiredNamespaces();
Severity: Minor
Found in includes/Search/SearchQuery.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

SearchQuery has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class SearchQuery {
    /**
     * Identifier for the fulltext SearchEngine entry point
     * @see \SearchEngine::searchText()
     */
Severity: Minor
Found in includes/Search/SearchQuery.php - About 2 hrs to fix

    Method __construct has 17 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            ParsedQuery $parsedQuery,
        array $initialNamespaces,
        CrossSearchStrategy $initialCrosswikiStrategy,
        array $contextualFilters,
        $searchEngineEntryPoint,
    Severity: Major
    Found in includes/Search/SearchQuery.php - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status