wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
includes/Search/TextIndexField.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function configureHighlighting has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    protected function configureHighlighting( array &$field, array $subFields, $rootField = true ) {
        if ( $this->mappingFlags & MappingConfigBuilder::OPTIMIZE_FOR_EXPERIMENTAL_HIGHLIGHTER ) {
            if ( $this->checkFlag( self::SPEED_UP_HIGHLIGHTING ) ) {
                if ( $rootField ) {
                    $field[ 'index_options' ] = 'offsets';
Severity: Minor
Found in includes/Search/TextIndexField.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getMapping has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getMapping( SearchEngine $engine ) {
        if ( !( $engine instanceof CirrusSearch ) ) {
            throw new \LogicException( "Cannot map CirrusSearch fields for another engine." );
        }
        $this->initFlags();
Severity: Major
Found in includes/Search/TextIndexField.php - About 2 hrs to fix

    Function getMapping has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getMapping( SearchEngine $engine ) {
            if ( !( $engine instanceof CirrusSearch ) ) {
                throw new \LogicException( "Cannot map CirrusSearch fields for another engine." );
            }
            $this->initFlags();
    Severity: Minor
    Found in includes/Search/TextIndexField.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status