wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
maintenance/UpdateOneSearchIndexConfig.php

Summary

Maintainability
D
2 days
Test Coverage

File UpdateOneSearchIndexConfig.php has 400 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace CirrusSearch\Maintenance;

use CirrusSearch\Connection;
Severity: Minor
Found in maintenance/UpdateOneSearchIndexConfig.php - About 5 hrs to fix

    UpdateOneSearchIndexConfig has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class UpdateOneSearchIndexConfig extends Maintenance {
        /**
         * @var string
         */
        private $indexSuffix;
    Severity: Minor
    Found in maintenance/UpdateOneSearchIndexConfig.php - About 3 hrs to fix

      Method execute has 75 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function execute() {
              $this->disablePoolCountersAndLogging();
      
              $utils = new ConfigUtils( $this->getConnection()->getClient(), $this );
      
      
      Severity: Major
      Found in maintenance/UpdateOneSearchIndexConfig.php - About 3 hrs to fix

        Method addSharedOptions has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function addSharedOptions( $maintenance ) {
                $maintenance->addOption( 'startOver', 'Blow away the identified index and rebuild it with ' .
                    'no data.' );
                $maintenance->addOption( 'indexIdentifier', "Set the identifier of the index to work on.  " .
                    "You'll need this if you have an index in production serving queries and you have " .
        Severity: Minor
        Found in maintenance/UpdateOneSearchIndexConfig.php - About 1 hr to fix

          Function execute has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function execute() {
                  $this->disablePoolCountersAndLogging();
          
                  $utils = new ConfigUtils( $this->getConnection()->getClient(), $this );
          
          
          Severity: Minor
          Found in maintenance/UpdateOneSearchIndexConfig.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method validateSpecificAlias has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function validateSpecificAlias() {
                  $connection = $this->getConnection();
          
                  $fieldsToCleanup = array_filter( explode( ',', $this->getOption( 'fieldsToDelete', '' ) ) );
                  $fieldsToCleanup = array_merge( $fieldsToCleanup, $this->getSearchConfig()->get( "CirrusSearchIndexFieldsToCleanup" ) );
          Severity: Minor
          Found in maintenance/UpdateOneSearchIndexConfig.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                    return true;
            Severity: Major
            Found in maintenance/UpdateOneSearchIndexConfig.php - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      try {
                          $indexSuffixes = $this->getConnection()->getAllIndexSuffixes( null );
                          if ( !in_array( $this->indexSuffix, $indexSuffixes ) ) {
                              $this->fatalError( 'indexSuffix option must be one of ' .
                                  implode( ', ', $indexSuffixes ) );
              Severity: Major
              Found in maintenance/UpdateOneSearchIndexConfig.php and 1 other location - About 2 hrs to fix
              maintenance/UpdateSuggesterIndex.php on lines 209..235

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status