File UpdateSuggesterIndex.php has 522 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

namespace CirrusSearch\Maintenance;

use CirrusSearch\BuildDocument\Completion\SuggestBuilder;

UpdateSuggesterIndex has 26 functions (exceeds 20 allowed). Consider refactoring.

Open

class UpdateSuggesterIndex extends Maintenance {
    /**
     * @var string language code we're building for
     */
    private $langCode;

Method indexData has 66 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function indexData(): int {
        // We build the suggestions by reading CONTENT and GENERAL indices.
        // This does not support extra indices like FILES on commons.
        $sourceIndexSuffixes = [ Connection::CONTENT_INDEX_SUFFIX, Connection::GENERAL_INDEX_SUFFIX ];

Function indexData has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.

Open

    private function indexData(): int {
        // We build the suggestions by reading CONTENT and GENERAL indices.
        // This does not support extra indices like FILES on commons.
        $sourceIndexSuffixes = [ Connection::CONTENT_INDEX_SUFFIX, Connection::GENERAL_INDEX_SUFFIX ];

• Read up
  Read up

Method execute has 60 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function execute() {
        global $wgLanguageCode,
            $wgCirrusSearchBannedPlugins,
            $wgCirrusSearchMasterTimeout;

Method recycle has 56 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function recycle() {
        $this->log( "Recycling index {$this->getIndex()->getName()}\n" );
        $this->recycle = true;
        $indexedDocs = $this->indexData();
        // This is fragile... hopefully most of the docs will be deleted from the old segments

Method canRecycle has 52 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function canRecycle() {
        global $wgCirrusSearchRecycleCompletionSuggesterIndex;
        if ( !$wgCirrusSearchRecycleCompletionSuggesterIndex ) {
            return false;
        }

Function recycle has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

Open

    private function recycle() {
        $this->log( "Recycling index {$this->getIndex()->getName()}\n" );
        $this->recycle = true;
        $indexedDocs = $this->indexData();
        // This is fragile... hopefully most of the docs will be deleted from the old segments

• Read up
  Read up

Method createIndex has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function createIndex() {
        // This is "create only" for now.
        if ( $this->getIndex()->exists() ) {
            throw new RuntimeException( "Index already exists." );
        }

Method __construct has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function __construct() {
        parent::__construct();
        $this->addDescription( "Create a new suggester index. Always operates on a single cluster." );
        $this->addOption( 'baseName', 'What basename to use for all indexes, ' .
            'defaults to wiki id', false, true );

Function canRecycle has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    private function canRecycle() {
        global $wgCirrusSearchRecycleCompletionSuggesterIndex;
        if ( !$wgCirrusSearchRecycleCompletionSuggesterIndex ) {
            return false;
        }

• Read up
  Read up

Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function execute() {
        global $wgLanguageCode,
            $wgCirrusSearchBannedPlugins,
            $wgCirrusSearchMasterTimeout;

• Read up
  Read up

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

        return true;

Avoid too many return statements within this method.

Open

            return false;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        try {
            $this->requireCirrusReady();
            $this->builder = SuggestBuilder::create( $this->getConnection(),
                $this->getOption( 'scoringMethod' ), $this->indexBaseName );
            # check for broken indices and delete them

• Read up
  Read up